Skip to content

emrg: GUI session list & title bar unified format project/name|id - #891

Merged
argszero merged 1 commit into
masterfrom
feature/gui-session-format
Aug 20, 2026
Merged

emrg: GUI session list & title bar unified format project/name|id#891
argszero merged 1 commit into
masterfrom
feature/gui-session-format

Conversation

@argszero

Copy link
Copy Markdown
Owner

Summary

Host feedback rant 2026-08-20T17:48:07: unify the session display format across the GUI sidebar history list, the open-sessions list, and the session title bar — all now use project/name|id.

Changes (6 files, +47/−70)

  1. sidebar.js — history list: removed the 今天/昨天/更早 time grouping; sessions sorted by last-active time (updated_at || created_at) descending; each item shows project/name|id where project = cwd basename, name = title (or empty), id = session_id.
  2. sidebar.js — open-sessions list: same project/name|id format (entry.projectName + title, id always shown).
  3. app.jsrenderSessionHeader(): unified to project/name|id (was project/title(sid) or project/sid); project fallback now also derives from the session's own cwd basename before home.
  4. i18n.js / utils.js — removed the now-unused util.group* keys and groupLabel() helper (orphan detection would flag them).
  5. Tests — conv-list boot test no longer expects group labels; open-session item test asserts the unified project/name|id format (id always present).

Verification

…nt 2026-08-20T17:48:07)

- sidebar render(): drop 今天/昨天/更早 time grouping, sort by last-active desc,
  item label = project/name|id (project = cwd basename, name = title||"", id = session_id)
- renderOpenSessions(): same unified format (entry.projectName + title, id always shown)
- app.js renderSessionHeader(): project/name|id (was project/title(sid) or project/sid)
- remove now-unused util.group* i18n keys + groupLabel() helper
- tests updated: conv-list no group labels; open-session items assert project/name|id

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 1 (6 files +47/−70: sidebar history list drops time grouping, sorts by last-active desc, unified project/name|id everywhere incl. header; orphan util.group* keys + groupLabel removed; tests updated to assert the new format; GUI 245 pass, test + test-windows CI PASS)

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 2 (independent re-review: head ad299bc unchanged; sidebar/header unified project/name|id, time-grouping removed, orphan keys cleaned; GUI 245 pass + pytest 981; test + test-windows CI PASS)

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 3 (re-review: head unchanged, GUI session/header project/name|id unified, time-grouping removed, orphan keys cleaned; GUI 245 pass + pytest 981; test + test-windows CI PASS, mergeable CLEAN)

@argszero
argszero merged commit 224dbd3 into master Aug 20, 2026
2 checks passed
@argszero
argszero deleted the feature/gui-session-format branch August 20, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant