emrg: deprecate emrgd.pid/emrgd.port in uninstaller (fixed-port + token ground truth) - #978
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260825-190924. CI: test + test-windows both pass. Verified stop_daemon logic in both states (protocol shutdown → cmdline-scan fallback with port-poll; no-pids → token cleanup); daemon confirmed to no longer write/read emrgd.pid/emrgd.port; full local suite 1071 passed/1 skipped + import + CLI OK. Consistent with emrg._stop_all semantics.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260825-192404. CI green (test + test-windows). Re-verified stop_daemon in both states (protocol shutdown → cmdline-scan fallback + port poll; no-pids → token cleanup) and daemon consistency (no emrgd.pid/port reads remain). Local suite green.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260825-193548 (3rd consecutive LGTM: 190924, 192404, 193548; no ❌ between). CI green (test + test-windows). PR remains limited to bin/emrg-uninstall + packaging/make-installer.sh — no daemon pid/port reads remain (verified ~/.emrg has only emrgd.token; daemon.py only docstring mention). Merge condition met.
Summary
Fully deprecate
~/.emrg/emrgd.pid/~/.emrg/emrgd.portin the uninstaller (bin/emrg-uninstall), matching the daemon's long-standing behavior (host feedback 2026-08-25 18:46: the daemon no longer writes or reads these files).Changes
bin/emrg-uninstall—stop_daemon()rewrite:PORT_FILE/PID_FILEconstants; the daemon is now identified solely by:56031(ground truth for daemon liveness, rant 2026-08-19T08:05:21), andemrgd.tokenfile (rant 2026-08-20T14:32:52).-m emrg.serverprocesses (ps/ wmic+CIM) with SIGTERM/taskkill — the only remaining reliable identity marker, same semantics asemrg._stop_all.stop_daemon(rant 2026-08-17T17:03:38).emrgd.pid/emrgd.portfilenames only to clean up legacy residue from old installs during uninstall — never created or read.packaging/make-installer.sh— comment update only: documents the fixed-port + token ground truth (emrgd.pid deprecated).Verification
python -c "from emrg.client.app import run_client"OK;python -m emrg --helpOKemrg/server/daemon.pyconfirmed to no longer write/reademrgd.pid/emrgd.port(only a docstring mention remains);~/.emrg/contains onlyemrgd.tokentodayNotes