Updates to Memory Manager and Garbage Collection Heuristics - #1241
Merged
Merged
Conversation
- Also changed CL_TO_AF_ERROR to display OpenCL error number
* Print memory size in CPU and OpenCL info * Change opencl::getDevice to accept id * Fix multi-line error strings
Member
There was a problem hiding this comment.
We should probably change this to a non zero value because we don't want to fail on platforms we haven't considered.
* Add getMaxMemorySize virtual function to MemoryManager
* Used to compute the max_bytes for each memory manager instance
* max_bytes
* This is now a part of memory_info
* Gets it's size from the device memory rather than a generic size
* For CPU and CUDA Pinned Memory, use getHostDeviceMemory
* Add getMaxBytes function to fetch the max_bytes of active device
* MAX_BUFFERS is now 1000
Fix missing include
Member
Author
|
build arrayfire osx ci |
/bigobj is now required for Debug builds for CPU. Since is it being used for 3 backends, it makes sense to move it into the central CMakeList
Member
Author
|
build arrayfire windows ci The cfd60f1 commit only affects Windows debug builds. So running only windows. |
Member
Author
|
build arrayfire windows ci |
* Fix vector in fast_pyramid - use resize instead of reserve * Fix meanshift test. Use proper types and arrays * Fix memory leak in basic_c * Enable solve tests that were disabled for windows opencl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1239
Fixes #1245