fix(openapi): preserve Analytics Discovery URLs - #76
Merged
Conversation
Keep Analytics Data and Admin on their service-hosted Discovery endpoints because the legacy Google Discovery directory returns 404 for both APIs.
Greptile SummaryPreserves Google Analytics Data and Admin service-hosted Discovery URLs and redirects their legacy directory forms to the corresponding service endpoints.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The new entries use the existing service override behavior, and the added tests cover both affected normalization paths used by the Analytics presets.
|
| Filename | Overview |
|---|---|
| packages/plugins/openapi/src/providers/google/discovery.ts | Adds Analytics Data and Admin to the established service-hosted URL preservation mechanism without introducing a concrete failure. |
| packages/plugins/openapi/src/providers/google/discovery.test.ts | Covers both legacy-directory rewriting and idempotent service-hosted normalization for the two Analytics APIs. |
Reviews (1): Last reviewed commit: "fix(openapi): preserve Analytics Discove..." | Re-trigger Greptile
aryasaatvik
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik
added a commit
that referenced
this pull request
Aug 27, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik
added a commit
that referenced
this pull request
Aug 28, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik
added a commit
that referenced
this pull request
Aug 29, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik
added a commit
that referenced
this pull request
Aug 29, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik
added a commit
that referenced
this pull request
Aug 31, 2026
## Summary Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs. ## Before / after | Input | Normalized endpoint | | --- | --- | | `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` | Preserved | | Legacy directory forms | Rewritten to the corresponding service-hosted endpoint | ## Validation - `tsgo` on changed source and tests - `oxlint --deny-warnings` on changed files - `vitest run` in `@executor-js/plugin-openapi` (270 tests) - Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs.
Before / after
analyticsdata.googleapis.com/$discovery/rest?version=v1betaanalyticsadmin.googleapis.com/$discovery/rest?version=v1betaValidation
tsgoon changed source and testsoxlint --deny-warningson changed filesvitest runin@executor-js/plugin-openapi(270 tests)