Skip to content

fix(openapi): preserve Analytics Discovery URLs - #76

Merged
aryasaatvik merged 1 commit into
devfrom
fix/google-analytics-discovery-urls
Aug 23, 2026
Merged

fix(openapi): preserve Analytics Discovery URLs#76
aryasaatvik merged 1 commit into
devfrom
fix/google-analytics-discovery-urls

Conversation

@aryasaatvik

Copy link
Copy Markdown
Owner

Summary

Keep Google Analytics Data and Admin Discovery URLs on their service-hosted endpoints. Google’s legacy Discovery directory returns HTTP 404 for both APIs.

Before / after

Input Normalized endpoint
analyticsdata.googleapis.com/$discovery/rest?version=v1beta Preserved
analyticsadmin.googleapis.com/$discovery/rest?version=v1beta Preserved
Legacy directory forms Rewritten to the corresponding service-hosted endpoint

Validation

  • tsgo on changed source and tests
  • oxlint --deny-warnings on changed files
  • vitest run in @executor-js/plugin-openapi (270 tests)
  • Reproduced the pre-fix HTTP 404 in the deployed add-integration flow

Keep Analytics Data and Admin on their service-hosted Discovery endpoints because the legacy Google Discovery directory returns 404 for both APIs.
@aryasaatvik
aryasaatvik merged commit 50d2d49 into dev Aug 23, 2026
3 of 36 checks passed
@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown

Greptile Summary

Preserves Google Analytics Data and Admin service-hosted Discovery URLs and redirects their legacy directory forms to the corresponding service endpoints.

  • Adds Analytics Data and Admin to the existing Google Discovery service override map.
  • Adds normalization coverage for legacy and service-hosted v1beta URLs.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The new entries use the existing service override behavior, and the added tests cover both affected normalization paths used by the Analytics presets.

Important Files Changed

Filename Overview
packages/plugins/openapi/src/providers/google/discovery.ts Adds Analytics Data and Admin to the established service-hosted URL preservation mechanism without introducing a concrete failure.
packages/plugins/openapi/src/providers/google/discovery.test.ts Covers both legacy-directory rewriting and idempotent service-hosted normalization for the two Analytics APIs.

Reviews (1): Last reviewed commit: "fix(openapi): preserve Analytics Discove..." | Re-trigger Greptile

aryasaatvik added a commit that referenced this pull request Aug 23, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik added a commit that referenced this pull request Aug 27, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik added a commit that referenced this pull request Aug 28, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik added a commit that referenced this pull request Aug 29, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik added a commit that referenced this pull request Aug 29, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
aryasaatvik added a commit that referenced this pull request Aug 31, 2026
## Summary

Keep Google Analytics Data and Admin Discovery URLs on their
service-hosted endpoints. Google’s legacy Discovery directory returns
HTTP 404 for both APIs.

## Before / after

| Input | Normalized endpoint |
| --- | --- |
| `analyticsdata.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| `analyticsadmin.googleapis.com/$discovery/rest?version=v1beta` |
Preserved |
| Legacy directory forms | Rewritten to the corresponding service-hosted
endpoint |

## Validation

- `tsgo` on changed source and tests
- `oxlint --deny-warnings` on changed files
- `vitest run` in `@executor-js/plugin-openapi` (270 tests)
- Reproduced the pre-fix HTTP 404 in the deployed add-integration flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant