Skip to content

Confluence: limit args does not work in get_all_pages_from_space function #1547

Description

@banziyeoh

Results length returned from the API will not trigger break if it equals to limit.

In line 677:

     if len(results) < limit:
                break

I am setting limit to 1 and results returned with size 1 will not meet this condition and causing additional API calls, even thought the limit has reached.

The fix:

     if len(results) <= limit:
                break

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions