Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

PR labels unreadable in dark themes #772

Description

@Arcanemagus

Description

The labels associated with a PR use the UI theme's text, but the background color from GitHub, leading to conflicts that can make them illegible.

Steps to Reproduce

  1. Have a branch checked out with an associated PR that has a label
  2. Attempt to read the label(s) of the PR

Expected behavior:

Labels are legible.

Actual behavior:

Since the labels use the theme color for text, if the theme uses a light color and the label has a light background it becomes near unreadable.

Atom Material (v2):
image

One Dark:
image

One Light: (as a usable example)
image

The label on github.com:
image

Reproduces how often:

100% of the time.

Versions

Windows 10 x64

Build from atom/atom@4cbff30.

Atom : 1.18.0-dev-4cbff3044 x64
Electron: 1.3.15
Chrome : 52.0.2743.82
Node : 6.5.0

github@0.0.2 (bundled in the build)

Additional Information

The PR/Branch in question was AtomLinter/linter-phpcs#261.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions