Skip to content

chore(v2): Split parameters module up by parameter provider - #1403

Merged
scottgerring merged 51 commits into
v2from
v2-split-params
Dec 11, 2023
Merged

chore(v2): Split parameters module up by parameter provider#1403
scottgerring merged 51 commits into
v2from
v2-split-params

Conversation

@scottgerring

@scottgerring scottgerring commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Issue #, if available:
#1402

Description of changes:

Checklist

Outstanding Changes

  • Migration guide
  • Documentation
  • AspectJ test coverage

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring changed the title v2: Split parameters module up by parameter provider chore: v2 - Split parameters module up by parameter provider Aug 29, 2023
@scottgerring scottgerring linked an issue Aug 29, 2023 that may be closed by this pull request
2 tasks
@scottgerring
scottgerring changed the base branch from main to v2 August 29, 2023 11:30
@codecov-commenter

codecov-commenter commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@00d04c3). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1403   +/-   ##
=====================================
  Coverage      ?   76.41%           
  Complexity    ?      517           
=====================================
  Files         ?       67           
  Lines         ?     2107           
  Branches      ?      242           
=====================================
  Hits          ?     1610           
  Misses        ?      421           
  Partials      ?       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread powertools-parameters/pom.xml
Comment thread powertools-parameters/powertools-parameters-appconfig/pom.xml
Comment thread powertools-parameters/powertools-parameters-tests/pom.xml
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated
Comment thread docs/utilities/parameters.md Outdated

@jeromevdl jeromevdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good

scottgerring and others added 2 commits December 11, 2023 12:43
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
…/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java

Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>

@jeromevdl jeromevdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 120 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring
scottgerring merged commit 6b0fe5a into v2 Dec 11, 2023
@scottgerring
scottgerring deleted the v2-split-params branch December 11, 2023 13:13
@jeromevdl

Copy link
Copy Markdown
Contributor

:bananadance:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Split powertools-parameters into submodules

3 participants