Skip to content

docs(event_handler): improve compress example using Response class - #2426

Merged
heitorlessa merged 1 commit into
aws-powertools:developfrom
heitorlessa:docs/event-handler-compress-response-object
Jun 9, 2023
Merged

docs(event_handler): improve compress example using Response class#2426
heitorlessa merged 1 commit into
aws-powertools:developfrom
heitorlessa:docs/event-handler-compress-response-object

Conversation

@heitorlessa

@heitorlessa heitorlessa commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Issue number: #1890

Summary

Expand code snippet to demonstrate how to use Response class when compress=True is set for a route.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa
heitorlessa requested a review from a team as a code owner June 8, 2023 15:24
@heitorlessa
heitorlessa requested review from leandrodamascena and removed request for a team June 8, 2023 15:24
@boring-cyborg boring-cyborg Bot added the documentation Improvements or additions to documentation label Jun 8, 2023
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2023
@heitorlessa heitorlessa linked an issue Jun 8, 2023 that may be closed by this pull request
@heitorlessa

Copy link
Copy Markdown
Contributor Author

@nilsm0hr - does this suffice in making the compress=True feature clearer when using the Response class?

@nilsm0hr

nilsm0hr commented Jun 9, 2023

Copy link
Copy Markdown

@heitorlessa Hi, this is superb! Thanks so much!

@heitorlessa
heitorlessa merged commit 9a45a01 into aws-powertools:develop Jun 9, 2023
@heitorlessa
heitorlessa deleted the docs/event-handler-compress-response-object branch June 9, 2023 09:48
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation event_handlers size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Understanding of the compress option

3 participants