fix(appsync): enhance consistency for custom resolver field naming in AppSync#5801
Merged
Conversation
pull-request-size
Bot
added
the
size/L
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5801 +/- ##
========================================
Coverage 96.17% 96.17%
========================================
Files 232 232
Lines 10940 10941 +1
Branches 2023 2023
========================================
+ Hits 10521 10522 +1
Misses 329 329
Partials 90 90 ☔ View full report in Codecov by Sentry. |
|
anafalcao
approved these changes
Dec 30, 2024
anafalcao
left a comment
anafalcao
left a comment
Contributor
There was a problem hiding this comment.
great job @leandrodamascena ! approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #5560
Summary
Changes
This PR aims to bring consistency to scenarios where customers want to use a custom resolver in AppSync to place fields outside of the
infoobject while maintaining consistency by using the same field nameparentTypeName.parentTypeNameboth inside and outside theinfoobjecttypeNameifparentTypeNameis not foundUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.