feat: add cross-platform utilities for Windows/Unix compatibility#16
Closed
tejaskash wants to merge 5 commits into
Closed
feat: add cross-platform utilities for Windows/Unix compatibility#16tejaskash wants to merge 5 commits into
tejaskash wants to merge 5 commits into
Conversation
…lity - Replace rsync with Node.js script (scripts/copy-assets.mjs) for copying assets - Replace 'rm -rf' with Node.js fs.rmSync for clean script - Fix AGENTS.md exclusion to only apply at root level, preserving src/assets/agents/AGENTS.md - Ensures build works on Windows without requiring Unix tools
- Check ptyAvailable flag before attempting to spawn script command - Skip warmup on Windows where PTY is not available - Prevents 'spawn script ENOENT' error on Windows - Falls back to one-shot command execution automatically
- Remove code that was overwriting postinstall with wrong package name - Template already has correct '@aws/agentcore-l3-cdk-constructs' in postinstall - Fixes npm link to use full scoped package name instead of 'agentcore' - Enables proper local development workflow with npm link
- Document npm link workflow for unpublished L3 constructs package - Include troubleshooting steps for common issues - Explain LOCAL_L3_PATH alternative approach - Helps developers work with local packages before npm publication
- Create platform utilities module (lib/utils/platform.ts) with: - getVenvExecutable() for Python venv paths (bin/ vs Scripts/) - Platform detection flags (isWindows, isMacOS, isLinux) - Shell command helpers (getShellCommand, getShellArgs) - Update dev server to use getVenvExecutable() for uvicorn path - Update persistent-shell to use isWindows flag - Abstracts platform differences for cleaner, maintainable code - Fixes dev server spawn error on Windows (ENOENT)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates comprehensive platform utilities to abstract Windows/Unix differences across the codebase.
Changes:
Provides a centralized way to handle platform-specific code paths.