Implement the Custom Endpoint Plugin#727
Merged
Merged
Conversation
aaron-congo
commented
Oct 31, 2024
Comment on lines
+266
to
+267
| hostnames = [host_info.host for host_info in hosts] | ||
| if self._reader_host_info is not None and self._reader_host_info.host not in hostnames: |
Contributor
Author
There was a problem hiding this comment.
We will hit this block whenever read_only is set to True. Are there performance concerns for this block? It is necessary to protect against the case where we have previously cached a reader instance connection but that reader instance was later removed from the custom endpoint. Without this check the read/write plugin would continue to use the cached reader connection to the now-blocked instance.
sergiyvamz
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.