add rexml dependency to support ruby v3 - #2457
Conversation
|
Thanks for the contribution! It looks like tests are failing for Ruby 1.9.3, which we unfortunately still need to support: However, it looks like this may be happening without this change as well. In previous runs, rexml was not being installed at all (eg: https://travis-ci.com/github/aws/aws-sdk-ruby/jobs/459953938). But that same change when re-run now does install rexml 3.2.4 (see: https://travis-ci.com/github/aws/aws-sdk-ruby/jobs/459953937). It looks like it has been added as an indirect dependency. That being said - we still have an issue I believe that adding a dependency on rexml breaks Ruby 1.9.3 and I'm not quite sure what we should do about that. |
|
Related: ruby/rexml#38 |
|
We discussed this a bit more in: ruby/rexml#38 and #2459 - and given the compatibility issues with Ruby 1.9 have decided against including rexml as an explicit dependency. rexml is currently used as the last resort xml engine so I've added an error message when none can be loaded. In almost all cases, other gems are already depending on at least one of the xml libraries we support so most users should not be impacted by rexml not being an explicit dependency (and in those cases, they can add it, or select any of the supported xml libraries). If you have a specific use case where this is required as a dependency in the sdk, lets chat! Otherwise, I'm going to close this PR - but thank you for opening it and kicking off such an important discussion! |
|
Now that the required Ruby version is 2.7+, would you reconsider adding |
ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/