Add repository field to package.json for npm provenance - #4
Conversation
Pull Request ReviewSummaryThis PR updates the CLI description by appending "2" to the description string. Based on the title "Test preview publish", this appears to be a test change to verify the publishing/preview workflow. Code Quality & Best Practices
Inconsistencies Detected
Potential Issues
Performance Considerations✅ No performance impact - this is a string literal change only. Security Concerns✅ No security concerns identified. Test Coverage
RecommendationIf this is a test PR: Close without merging after verifying the preview/publish workflow works correctly. If this is an intentional change:
Please clarify the intent of this PR so I can provide more specific guidance. |
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.1-pr.4.36be66ePrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.1-pr.4.36be66e"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.1-pr.4.36be66e"
}
}
Preview published to npm registry — try new features instantly! |
Pull Request ReviewSummaryThis PR adds repository metadata to Code Quality & Best Practices✅ Positive:
Recommendation: Potential Bugs or IssuesMinor Inconsistency:
Security Concerns✅ No security issues identified
Test Coverage
Performance Considerations✅ No performance impact
RecommendationIf this is for testing preview publish: Revert the description change in If the description change is intentional: Update "description": "Base44 CLI 2 - Unified interface for managing Base44 applications",The repository field addition is good and should be kept regardless. |
Pull Request ReviewOverviewThis PR adds the ✅ Code Quality & Best Practices
🔍 Potential Issues & Suggestions1. Repository URL FormatThe current URL format is missing the Current: "url": "https://github.com/base44/cli"Recommended: "url": "git+https://github.com/base44/cli.git"This follows the npm package.json specification more precisely and ensures better compatibility with various tools. 2. Additional Repository Metadata (Optional)Consider adding the 🔒 Security Considerations
🚀 Performance Considerations
🧪 Test Coverage
📝 SummaryVerdict: ✅ Approve with minor suggestion This is a necessary and well-executed change. The only improvement would be to use the more complete URL format ( Action items before merge (optional):
Great work addressing the npm provenance requirement! 🎉 |
- Rename loop variable `i` to `integration` (review #2) - Use typed destructuring instead of Record<string, unknown> (review #3) - Extract reusable formatYaml() utility with stripEmpty option (review #4) - Use lodash isEmpty for null/empty stripping in YAML replacer - Add formatYaml unit tests - Update test assertions for integrationType key rename Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename loop variable `i` to `integration` (review #2) - Use typed destructuring instead of Record<string, unknown> (review #3) - Extract reusable formatYaml() utility with stripEmpty option (review #4) - Use lodash isEmpty for null/empty stripping in YAML replacer - Add formatYaml unit tests - Update test assertions for integrationType key rename Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat(connectors): add `connectors list-available` command Add a new CLI command to discover all available integration types from the Base44 catalog endpoint (GET /external-auth/available-integrations). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address review — remove unused type, add min(1) to integration_type Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: align schema with apper commit 7556a23 - Wrapper key: `available_integrations` → `integrations` - Remove `notes` and `usage_guide` fields (dropped from backend) - Extract long template literal for readability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: output full JSON for list-available Print the complete integration data (including connection_config_fields) as JSON to stdout so LLMs and scripts can consume all fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: YAML-formatted output for list-available - Add yaml dep for pretty-printing integration details - Display each integration as YAML (type, description, config fields) - Keep connection_config_fields in snake_case (no transform) - Remove temp fake fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: restore camelCase transform for connection config fields Keep consistent with codebase convention — convert snake_case to camelCase at the Zod boundary for all fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: add .claude/worktrees/ to gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address review findings for list-available - Use camelCase key `connectionConfigFields` in YAML output - Strip null/undefined values from config fields before display - Add comment explaining z.string() choice over IntegrationTypeSchema - Add test for malformed API response (Zod validation) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract formatYaml helper, address review findings - Rename loop variable `i` to `integration` (review #2) - Use typed destructuring instead of Record<string, unknown> (review #3) - Extract reusable formatYaml() utility with stripEmpty option (review #4) - Use lodash isEmpty for null/empty stripping in YAML replacer - Add formatYaml unit tests - Update test assertions for integrationType key rename Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: update bun.lock for yaml dependency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: use main's root package.json for monorepo paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style: fix Biome formatting in yaml tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Adds the
repositoryfield topackage.jsonto fix npm publish with provenance verification.Changes
repository.typeandrepository.urlfields pointing tohttps://github.com/base44/cliWhy
npm's sigstore provenance verification requires the
repository.urlinpackage.jsonto match the GitHub repository from which the package is being published.