fix: don't sync *.tmp files on watch#31
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
added a commit
that referenced
this pull request
Feb 28, 2026
search_notes was returning individual observations and relations as separate top-level results, wasting the result limit and creating confusing UX. Default entity_types to ["entity"] when the caller doesn't specify it — the entity row already indexes full file content, so no matches are lost. Users can still override with explicit entity_types=["observation"] etc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>
Member
Author
|
Fixed in 2c5b63c. |
phernandez
added a commit
that referenced
this pull request
Feb 28, 2026
Add write_note overwrite guard (#632) to new capabilities, 8 bug fixes (#631, #630, #30, #31, #28, plus schema_validate/Post/frontmatter fixes), and write_note idempotency breaking change to upgrade notes. Bump commit count from 80+ to 90+. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
added a commit
that referenced
this pull request
Jun 7, 2026
search_notes defaults entity_types to 'entity' when unset (issue #31), but categories only exist on observations — so search_notes(categories=[...]) without entity_types ANDed the category against entity rows (NULL category) and returned nothing. When categories is supplied without an explicit entity_types, default to observations instead. Adds a regression test for the categories-only path (Codex review on #908). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30