fix(ci): make BM Bossbot asset cleanup idempotent#935
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
0c886d5 to
2de1971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rm --ignore-unmatch.Verification
uv run pytest tests/ci/test_bm_bossbot_workflow.py -quv run ruff check tests/ci/test_bm_bossbot_workflow.pygit diff --checkContext
Fixes the non-gating asset publishing annotation seen in BM Bossbot Assets for PR #928, where
git rm -rf .failed aftergit switch --orphanbecause no paths matched.Reviewed SHA:
ec94feb6a411d44e941e63daf95c56175659772cVerdict:
approveStatus:
success- BM Bossbot approved this head SHASummary:
No blocking issues found. The workflow cleanup now tolerates an empty orphan-branch index with
git rm -rf --ignore-unmatch ., which matches the reported failure mode, and the CI test adds a direct regression assertion for the idempotent cleanup command.Blocking findings:
Non-blocking findings:
BM Bossbot image provenance
#935/home/runner/work/basic-memory/basic-memory/docs/assets/infographics/pr-935.webpgpt-image-21536x1024highautononeTheme / choice instruction:
None supplied.
Image prompt sent to
gpt-image-2:Images API revised prompt:
Not provided by the Images API.