ci(ci): gate bossbot on passing tests

[phernandez]

Summary

• Move BM Bossbot automatic reviews behind successful Tests workflow runs instead of direct PR events.
• Add stale-head and manual-dispatch guards so Bossbot skips Codex/status/image work unless the current PR head has green tests.
• Make PR visuals image-first with deterministic BM visual directions and compact provenance focused on theme/settings instead of dumping the full prompt.

Verification

• uv run pytest tests/ci/test_bm_bossbot_workflow.py tests/scripts/test_generate_pr_infographic.py tests/test_codex_plugin_package.py -q
• uv run ruff check scripts/generate_pr_infographic.py tests/ci/test_bm_bossbot_workflow.py tests/scripts/test_generate_pr_infographic.py tests/test_codex_plugin_package.py
• just typecheck
• just package-check

Reviewed SHA: 1da2ec08ba2ea5f80ebf308b6d2853efdd487981
Verdict: approve
Status: success - BM Bossbot approved this head SHA

Summary:
Reviewed the full provided diff against the Basic Memory engineering style and Bossbot merge-gate priorities. The prior manual-dispatch blocker is addressed by matching the push-only Tests workflow, and I found no remaining concrete merge blockers.

Blocking findings:

• None

Non-blocking findings:

• None

BM Bossbot image provenance

• Pull request: #937
• Generated asset: /home/runner/work/basic-memory/basic-memory/docs/assets/infographics/pr-937.webp
• Image model: gpt-image-2
• Size: 1536x1024
• Quality: high
• Visual format: auto
• Theme source: none

Theme / choice instruction:
None supplied.

Image prompt sent to gpt-image-2:

Create a polished landscape WebP visual for Basic Memory PR #937.

This is a non-gating visual summary. The authoritative merge gate is the
GitHub commit status named BM Bossbot Approval, not this image.

Use the BM Bossbot review summary below as source material. Preserve the
concrete before/after value story without inventing facts or turning
implementation details into clutter.

Choose the most appropriate visual form: infographic, map, scene, poster,
painting, tableau, cover image, illustrated artifact, or another image form that
best communicates the PR intent. Choose exactly one visual mode and follow only
that mode's rules. Do not blend the modes.

Mode A - infographic/map:
- Use a readable map backbone with structured information design: sections,
  route lines, checkpoints, nodes, annotations, status badges, compact evidence
  bullets, and a legend.
- Use this mode when the PR needs several facts, gates, checks, or before/after
  points to be read explicitly.

Mode B - editorial scene/poster/painting:
- Use image-first composition: an actual scene, movie poster, painting, tableau,
  cover image, or symbolic illustrated artifact.
- Use this mode when the PR intent can be shown through one staged visual moment
  with minimal text.
- Avoid dashboard layouts, data panels, timeline strips, flowcharts, legends,
  before/after boxes, bullet lists, and checklist columns in this mode.

The visual theme should drive the composition through original style cues while
the engineering meaning stays easy to scan.

Use high contrast, smooth anti-aliased text when text is present, clean edges,
and non-tiny labels. Text is optional for scene-first images, but any text that
appears must be readable.

Avoid fake screenshots, code blocks, invented claims, copyrighted characters,
logos, named fictional universes, direct band logos, album art, celebrity
likenesses, or decorations that obscure content.

BM Bossbot summary:
Reviewed SHA: `1da2ec08ba2ea5f80ebf308b6d2853efdd487981`
Verdict: `approve`
Status: `success` - BM Bossbot approved this head SHA

Summary:
Reviewed the full provided diff against the Basic Memory engineering style and Bossbot merge-gate priorities. The prior manual-dispatch blocker is addressed by matching the push-only Tests workflow, and I found no remaining concrete merge blockers.

Blocking findings:
- None

Non-blocking findings:
- None

Images API revised prompt:
Not provided by the Images API.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b132588ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Query the push-triggered Tests runs on manual dispatch

When BM Bossbot is run via workflow_dispatch, this lookup asks GitHub for successful test.yml runs whose event is pull_request, but I checked .github/workflows/test.yml and it only triggers on push. The REST workflow-runs event parameter filters by the triggering event, so even a current PR head with green Tests will return no rows here, set should_review=false, and skip Codex/status/assets for the manual fallback path.

Useful? React with 👍 / 👎.