Skip to content

test(mcp): assert tags param and tag: shorthand comma equivalence#943

Merged
phernandez merged 1 commit into
mainfrom
test/910-tags-shorthand-equivalence
Jun 10, 2026
Merged

test(mcp): assert tags param and tag: shorthand comma equivalence#943
phernandez merged 1 commit into
mainfrom
test/910-tags-shorthand-equivalence

Conversation

@phernandez

@phernandez phernandez commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

Carries the remaining piece of #918 by @jagadeeswara-ks, with original commit authorship preserved — please rebase-merge this PR (not squash) so the commit lands on main credited to its author.

@jagadeeswara-ks had the correct fix for #910 in review before our duplicate (#932) merged and auto-closed the issue. The validator swap (coerce_listparse_tags) is therefore already on main, but his integration regression test is additive: nothing else asserts end-to-end that search_notes(tags="alpha,beta") and the tag:alpha,beta query shorthand return the same results for the same comma string — and that equivalence is the heart of #910.

The cherry-pick keeps his test verbatim and drops only the already-landed search.py hunk; his DCO sign-off is intact.

Test plan

  • uv run pytest "test-int/mcp/test_search_integration.py::test_tags_param_vs_tag_query_comma_consistency" -q — passes on current main

Refs #910, #918

🤖 Generated with Claude Code

Reviewed SHA: 61ea09968889a3628c4952e9d80b436878d26147
Verdict: approve
Status: success - BM Bossbot approved this head SHA

Summary:
Reviewed the full provided diff for head SHA 61ea099. The added integration regression test exercises the MCP client/server path and introduces no blocking correctness, packaging, workflow, or compatibility risk.

Blocking findings:

  • None

Non-blocking findings:

  • Targeted test not run in sandbox: The filesystem is read-only in this review environment, so I did not run the pytest target. The provided diff is test-only, scoped to the MCP search integration suite, and the assertion would catch the original regression where tags='alpha,beta' was treated as one literal tag while tag:alpha,beta split correctly.

BM Bossbot image for PR #943

BM Bossbot image choices
  • Pull request: #943
  • Generated asset: /home/runner/work/basic-memory/basic-memory/docs/assets/infographics/pr-943.webp
  • Image model: gpt-image-2
  • Size: 1536x1024
  • Quality: high
  • Image mode: editorial-image
  • Theme source: auto

Theme / visual direction:

Italian movie poster: hand-painted drama, expressive color, credit-block energy, and 1960s or 1970s cinema composition with no actor likenesses

Integration regression test for #910: the tags= parameter and the
tag:alpha,beta query shorthand must return the same results for the
same comma string.

Cherry-picked from #918. The validator swap itself (coerce_list ->
parse_tags) landed separately via #932; this carries the remaining
test-only piece with original authorship.

Signed-off-by: K Jagadeeswara Reddy <social@jagadeeswar.com>
@phernandez phernandez force-pushed the test/910-tags-shorthand-equivalence branch from 32d2356 to 61ea099 Compare June 10, 2026 16:02
@phernandez phernandez merged commit 44ecec2 into main Jun 10, 2026
39 of 40 checks passed
@phernandez phernandez deleted the test/910-tags-shorthand-equivalence branch June 10, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants