test(mcp): assert tags param and tag: shorthand comma equivalence#943
Merged
Conversation
This was referenced Jun 10, 2026
Integration regression test for #910: the tags= parameter and the tag:alpha,beta query shorthand must return the same results for the same comma string. Cherry-picked from #918. The validator swap itself (coerce_list -> parse_tags) landed separately via #932; this carries the remaining test-only piece with original authorship. Signed-off-by: K Jagadeeswara Reddy <social@jagadeeswar.com>
32d2356 to
61ea099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries the remaining piece of #918 by @jagadeeswara-ks, with original commit authorship preserved — please rebase-merge this PR (not squash) so the commit lands on main credited to its author.
@jagadeeswara-ks had the correct fix for #910 in review before our duplicate (#932) merged and auto-closed the issue. The validator swap (
coerce_list→parse_tags) is therefore already on main, but his integration regression test is additive: nothing else asserts end-to-end thatsearch_notes(tags="alpha,beta")and thetag:alpha,betaquery shorthand return the same results for the same comma string — and that equivalence is the heart of #910.The cherry-pick keeps his test verbatim and drops only the already-landed
search.pyhunk; his DCO sign-off is intact.Test plan
uv run pytest "test-int/mcp/test_search_integration.py::test_tags_param_vs_tag_query_comma_consistency" -q— passes on current mainRefs #910, #918
🤖 Generated with Claude Code
Reviewed SHA:
61ea09968889a3628c4952e9d80b436878d26147Verdict:
approveStatus:
success- BM Bossbot approved this head SHASummary:
Reviewed the full provided diff for head SHA 61ea099. The added integration regression test exercises the MCP client/server path and introduces no blocking correctness, packaging, workflow, or compatibility risk.
Blocking findings:
Non-blocking findings:
BM Bossbot image choices
#943/home/runner/work/basic-memory/basic-memory/docs/assets/infographics/pr-943.webpgpt-image-21536x1024higheditorial-imageautoTheme / visual direction: