First attempt enabling exclude port list capability Issue #530 - #534
Conversation
|
Fixes Issue #530 |
|
Thanks for this! Let me run CI :) |
|
:( CI fails due to linter changing, i canlook at this |
|
i will give it a try and see |
|
Hi! Mind pushing an empty commit? CI has failed to pick this up and I think it'll only pick it up on a new commit? 🤔 |
|
Sure
I'll do on Monday as I'm traveling
El sáb, 6 abr. 2024 17:58, Autumn ***@***.***> escribió:
… Hi! Mind pushing an empty commit? CI has failed to pick this up and I
think it'll only pick it up on a new commit? 🤔
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDVBTOSANICYWE5WLDPMTDY4BOYLAVCNFSM6AAAAABCMIE5Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGIYDGOJSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Done! |
|
Thanks @wasuaje. mhhm seems like the CI workflows haven't ran here? It looks like it's waiting for approval from a maintainer before the build checks are ran @bee-san https://github.com/RustScan/RustScan/actions/runs/8600212606 And if you look at our workflows they are also requiring actions on our side now (https://github.com/RustScan/RustScan/actions) before running. Strange how this is suddenly a problem/thing. I wonder if the actual runners themselves changed recently? |
|
CI running! |
|
Nice!
El lun, 8 abr 2024 a las 13:31, Autumn (Bee) ***@***.***>)
escribió:
… CI running!
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDVBTMXYGVSNOYTYODS4BDY4LA6JAVCNFSM6AAAAABCMIE5Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGE4DQNZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just need to run cargo fmt! |
|
Forgot to run cargo fmt without the check parameter, now it is ok, can retry the CI |
Cargo clippy is failing :P |
|
Make sure:
Are all ok and it should be ok! |
|
Ok will run those
El mar, 9 abr 2024 a las 4:27, Autumn (Bee) ***@***.***>)
escribió:
… Make sure:
- Cargo fmt
- Cargo clippy
- Cargo test
Are all ok and it should be ok!
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDVBTOMGRGUPZJRPA2PVVLY4OJ67AVCNFSM6AAAAABCMIE5Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGMZDCNZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Done, all ok! |
|
cargo clippy is still failing :( |
| .order() | ||
| .iter() | ||
| .filter(|&port| !self.exclude_ports.contains(port)) | ||
| .cloned() |
|
Fixed!
El mar, 9 abr 2024 a las 14:09, Autumn (Bee) ***@***.***>)
escribió:
… cargo clippy is still failing :(
error: used `cloned` where `copied` could be used instead
Error: --> src/scanner/mod.rs:75:14
|
75 | .cloned()
| ^^^^^^ help: try: `copied`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied
= note: `-D clippy::cloned-instead-of-copied` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::cloned_instead_of_copied)]`
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDVBTNX346THGVOPGF4SD3Y4QOGBAVCNFSM6AAAAABCMIE5Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVG4YDSOBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
thank you!! |
4 participants
Added option to exclude port from scanning, so now users can run
rustscan -b 2000 -t 5000 -a 127.0.0.1 --ulimit 5000 --exclude-ports 9000,8000And get the desired ports excluding the provided list.