Capture a new frame at cam.capture() call, avoid buffered frames#29
Closed
hypersolution1 wants to merge 4 commits into
Closed
Capture a new frame at cam.capture() call, avoid buffered frames#29hypersolution1 wants to merge 4 commits into
hypersolution1 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fix a bug about frame grabbing. With the original code, calling cam.start() starts filling the 4 buffers internally. Suppose you want to grab a frame after some event, ex. by calling cam.capture(...) in 5 seconds, cam.frameRaw() won't contain the frame at the time of cam.capture() call but at cam.start() call. Because of the 4 buffers, you need to call cam.capture() 4 times before starting to get recent frames. In your examples, the workaround you provide is to call cam.capture() continuously so the buffers is constantly renewed.
To make it work, it seems that you need to provide at least 1 buffer to the driver so it could fill it. In the Capture function, I discard the buffer and I wait for the driver to grab a frame at the moment of the capture call. Also, this is why I reduced the internal buffers from 4 to 1.