Skip to content

Improve handling for invalid core files - #358

Open
godlygeek wants to merge 1 commit into
bloomberg:mainfrom
godlygeek:handle_bad_core_files
Open

godlygeek wants to merge 1 commit into
bloomberg:mainfrom
godlygeek:handle_bad_core_files

Conversation

@godlygeek

@godlygeek godlygeek commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Prevent reading past the end of a truncated or malformed core file's NT_FILE note.

@godlygeek godlygeek self-assigned this Sep 17, 2026
@godlygeek
godlygeek requested a review from a team September 17, 2026 22:42
@codecov-commenter

codecov-commenter commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.18%. Comparing base (a0ec380) to head (11d9cb4).

Files with missing lines Patch % Lines
src/pystack/_pystack/corefile.cpp 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   78.19%   78.18%   -0.01%     
==========================================
  Files          58       58              
  Lines        6690     6697       +7     
  Branches      630      631       +1     
==========================================
+ Hits         5231     5236       +5     
- Misses       1459     1461       +2     
Flag Coverage Δ
cpp 78.18% <77.77%> (-0.01%) ⬇️
python 78.18% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godlygeek
godlygeek requested a review from pablogsal September 17, 2026 22:53
@godlygeek
godlygeek force-pushed the handle_bad_core_files branch 2 times, most recently from d51c2b6 to cf28439 Compare September 18, 2026 17:18
@godlygeek godlygeek changed the title Improve handling for unsupported core files Improve handling for invalid core files Sep 18, 2026
Prevent reading past the end of a truncated or malformed core file's
`NT_FILE` note.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek
godlygeek force-pushed the handle_bad_core_files branch from cf28439 to 11d9cb4 Compare September 18, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants