docs: followup_review_recommended is now scored upstream (BMAD-METHOD#2580) - #134
Conversation
…#2580) Upstream #2580 replaced step-04's convergence-prone significance judgment with a severity-weighted score over patched findings (any high, or 3*medium + 1*low >= 5) and routes patches back to the step-03 implementer with re-verification. The default review layers are also four now (the inline Intent Alignment Auditor landed in #2560). Prose-only refresh: README, FEATURES, TUI guide, the [review].enabled setting description, and the engine's damping comments no longer state the old always-recommends behavior as present-tense fact or hardcode the layer count. limits.max_followup_reviews is unchanged — #2580 explicitly leaves budgeting/damping to the orchestrator.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughDocumentation, settings descriptions, and engine comments now describe severity-weighted ChangesReview semantics
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Prose-only refresh after upstream BMAD-METHOD#2580 merged. No behavior change —
limits.max_followup_reviews(default 1) and all code paths stay as they are.[review].enableddescription — stop hardcoding the layer count ("triple-review", "three-layer", "Blind + Edge-Case hunters") and the old judgment wording. The skill's default review layers are four now (the inline Intent Alignment Auditor landed in #2560), andfollowup_review_recommendedis computed from a severity-weighted score over the final pass's patched findings (anyhigh, or3×medium + 1×low ≥ 5) instead of a significance judgment.[review].enabledcomment said "quick-dev's own internal triple-review"; the loop drivesbmad-dev-auto, fixed alongside.Why
Our #126→#124 damping work documented the upstream non-convergence as a live failure mode. #2580 fixes it at the source (closing our #2576 and #2570) and explicitly leaves "budgeting and damping" to the orchestrator — so the knob remains as the orchestrator-side bound, now belt-and-suspenders, and the docs should say so.
Testing
trunk check: no issues.🤖 Generated with Claude Code
Summary by CodeRabbit
Changed
Documentation