Skip to content

🔧 ci: pin Deno to v2.8.3 to work around v2.9.0 JSR warm-cache regression#105

Merged
dreyfus92 merged 1 commit into
mainfrom
fix-cache-bug
Jul 1, 2026
Merged

🔧 ci: pin Deno to v2.8.3 to work around v2.9.0 JSR warm-cache regression#105
dreyfus92 merged 1 commit into
mainfrom
fix-cache-bug

Conversation

@cowboyd

@cowboyd cowboyd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Pins deno-version to v2.8.3 in size-report.yml and verify.yaml (previously v2.x, which floats to v2.9.0).

Deno v2.9.0 has a regression denoland/deno#35529 where JSR files that have no manifest checksum (e.g. @ts-morph/common@0.27.0's dynamic require("./crypto"), which resolves to a nonexistent file) pass on cold download but fail integrity check on warm cache:

error: Integrity check failed in package.
  Specifier: https://jsr.io/@ts-morph/common/0.27.0/crypto
  Actual:   e3b0c442…  (sha256 of empty bytes)
  Expected: package-manifest-missing-checksum

The Size Report workflow builds twice on one runner (head, then base) sharing ~/.cache/deno. The head build downloads fresh and passes; the base build hits the warm cache and errors — example failing run. Every Size Report run since 2026-06-30 has failed this way. Verify hasn't been bitten yet because it only builds once per runner, but I pinned it too so the next non-trivial refactor doesn't reintroduce a double build.

The upstream fix has been merged but no v2.9.1 tag exists yet. A comment in each workflow says to restore v2.x once it ships.

Type of change

  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test) — CI verifies
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable) — n/a
  • I have added a changeset — n/a, CI-only change

AI-generated code disclosure

  • This PR includes AI-generated code

v2.9.0 fails JSR integrity checks on warm cache for files without a
manifest checksum (denoland/deno#35529). Size Report builds twice on
the same runner, so the base build hits the cache and errors on
`@ts-morph/common@0.27.0`'s dynamic `require("./crypto")`.

Restore `v2.x` once v2.9.1 ships.
@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tty@105

commit: 35219e9

@cowboyd cowboyd requested review from jbolda and natemoo-re and removed request for natemoo-re July 1, 2026 14:06
@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 10.29%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 8 untouched benchmarks
⏩ 18 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime pack complex layout 47.8 ms 53.4 ms -10.54%
WallTime pack large list 63.4 ms 70.5 ms -10.03%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix-cache-bug (35219e9) with main (9de7762)2

Open in CodSpeed

Footnotes

  1. 18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (5e253a7) during the generation of this report, so 9de7762 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@jbolda

jbolda commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

(In our meeting discussing this and) we acknowledge that this change shouldn't effectively be a regression. Something is going on and being a little funky with the results. We don't have our permissions squared away yet to mark this as an "Ok regression" (and is it really?) so it feels reasonable to proceed with merging.

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you both ✌🏻

@dreyfus92 dreyfus92 merged commit 5b2124e into main Jul 1, 2026
11 of 12 checks passed
@dreyfus92 dreyfus92 deleted the fix-cache-bug branch July 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants