fix: generate alphanumeric CNPJs using the full A-Z alphabet#498
Open
joaopedroassad wants to merge 1 commit into
Open
fix: generate alphanumeric CNPJs using the full A-Z alphabet#498joaopedroassad wants to merge 1 commit into
joaopedroassad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
generateCnpj(2)builds the alphanumeric base from a restricted character set that drops the letters E, O, T, and U:isValidCnpj(..., { version: 2 })accepts the full[A-Z0-9]range, so the generator and the validator disagree: the generator can never emit a valid CNPJ containing E, O, T, or U, even though those CNPJs are valid.This is the same restricted alphabet that #461 already removed from the alphanumeric sanitization path (closing #460); the generator was just left untouched at the time.
What changed
VALID_CNPJ_CHARSingenerate-cnpj.tsto the full0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ. The checksum already usescharCodeAt(0) - 48, which is correct for every A-Z, so no other change is needed.Testing
vp test run(full suite): 561 passed, 4 skipped.vp check: formatting and lint clean.