fix(pg-cloudflare): safely end already-closed sockets#3718
Open
deepakganesh78 wants to merge 1 commit into
Open
fix(pg-cloudflare): safely end already-closed sockets#3718deepakganesh78 wants to merge 1 commit into
deepakganesh78 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudflareSocket.end()tolerate the underlying socket having already closedpg-cloudflareunit-test support and regression coverage for the close-handler lifecycleRoot cause
_addClosedHandler()clears_cfSocketbefore emittingclose. A laterend()/destroy()still dereferenced_cfSocketafter its write callback, causing a synchronousnull.close()crash during client cleanup. The guarded close treats the already-closed state as complete without swallowing write errors or skipping the callback.Related to #3695, which proposed the guard; this includes the regression test requested in that PR.
Tests
corepack yarn workspace pg-cloudflare test— 2 passingcorepack yarn buildcorepack yarn eslint --cache "packages/**/*.{js,ts,tsx}"Fixes #3689