fix(pg): do not treat Sync as connection ending - #3772
Open
devtechedge wants to merge 1 commit into
Open
Conversation
Connection.sync() was setting _ending=true on every extended-query Sync. That flag is meant for disconnect (Terminate / end()), so after the first parameterized query ECONNRESET and EPIPE were swallowed for the life of the connection. Keep _ending only on end() and connect-timeout teardown. Fixes brianc#3769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3769.
Connection.sync()was setting_ending = trueon every extended-query Sync. That flag exists soreportStreamErrorcan ignoreECONNRESET/EPIPEduring disconnect. Sync is the protocol barrier after Parse/Bind/Execute, not a disconnect, so after the first parameterized query those socket errors were silently dropped for the rest of the connection lifetime.With
pipeline: truethat interacts badly with unexpected pooler/socket teardowns: the normal error path is closed and recovery depends only on the asyncclose/endpath, which can leave an in-flight query promise unsettled.Changes
_endinginsync(); leave it set only inend()(Terminate) and the connect-timeout teardown path that already setscon._ending = truebefore destroying the stream._endingfalse and thatECONNRESETafter Sync still emitserror(existing disconnect coverage still usesend()).Test plan
node test/unit/connection/error-tests.js(new cases green)packages/pgunit suite (find test/unit -name '*-tests.js' | xargs -n1 node) - 284 pass