Let Users pass dynamic path to read main and test apks#68
Merged
Conversation
deepwired
requested changes
Jan 2, 2023
| }); | ||
| } | ||
|
|
||
| Files.find(Paths.get(dir), Constants.APP_SEARCH_MAX_DEPTH, (filePath, fileAttr) -> isValidFile(filePath, fileAttr)) |
Collaborator
There was a problem hiding this comment.
if both paths are provided no need to execute below loop on files
| Files.find(Paths.get(dir), Constants.APP_SEARCH_MAX_DEPTH, (filePath, fileAttr) -> isValidFile(filePath, fileAttr)) | ||
| .forEach(f -> { | ||
|
|
||
| if (f.toString().endsWith("-androidTest.apk")) { |
Collaborator
There was a problem hiding this comment.
might as well combine these if statements !isAPKFileCreated[1] && f.toString().endsWith("-androidTest.apk")
deepwired
requested changes
Jan 3, 2023
deepwired
reviewed
Jan 5, 2023
| stdout = run_command(gradle_command) | ||
| responses = stdout.lines.select{ |line| line.match(/DebugApp apk: null|TestApp apk: null/)} | ||
| if responses.count != 2 | ||
| puts "✘ #{gradle_command} failed with error: #{responses}".red |
Collaborator
There was a problem hiding this comment.
if we are expecting this unit test to fail, can we change the color indication to green here, and red for the else condition?
deepwired
previously approved these changes
Jan 5, 2023
| def run_test_with_ipa | ||
| puts "Running tests with ipa files" | ||
| mainAPKPath = $current_path + "/test/mainApk/ipa" | ||
| testAPKPAth = $current_path + "/test/mainApk/ipa" |
There was a problem hiding this comment.
This will pick the same app, can we point it to any other path with apk test
Contributor
Author
There was a problem hiding this comment.
Changes pushed.
sauravdas1997
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://browserstack.atlassian.net/browse/AASI-2063
This change will let user pass paths to their main and test apks.
Example command:-
./gradlew executeDebugTestsOnBrowserstack -PmainAPKPath=/Users/richa/Documents/gradle_richa/test/mainApk -PtestAPKPath=/Users/richa/Documents/gradle_richa/test/testApk
Latest APKs present in the given folder will be picked for execution.