move useful parts of BMO extension schema to core#31
Conversation
|
I'm not yet familiar with the code base to review this adequately, but I'll try to have a closer look tomorrow :) |
CyberShadow
left a comment
CyberShadow
left a comment
There was a problem hiding this comment.
I had to break up the first commit into several to look at it piecewise. Looks like this is 90% of moving code around. Would be prudent to review all usages of moved symbols to ensure they're not affected.
Another thing is that it would make sense to remove the "BMO - " markers from comments at sites using features that are being moved to core. We can then use the remaining instances as a signal of what else needs to be done in core for further separation from BMO stuff.
There was a problem hiding this comment.
Guessing it's OK to just drop this migration code?
There was a problem hiding this comment.
I think this is supposed to be always_fileable_groups (one l).
2 participants
Part of this was previously commited to unstable, but that wasn't reviewed by anyone and wasn't complete...