Bug 1446236 - Fix instant search without GuidedBugEntry#38
Merged
dylanwh merged 3 commits intoApr 8, 2018
Merged
Conversation
getProduct had a hard dependency on the 'products' object, which is provided by products.js from the GuidedBugEntry extension. Check if the products variable exists before attempting to use it. This can happen when loading products.js fails, which in turn can happen when the GuidedBugEntry extension isn't present.
Fixes a 404 if the GuidedBugEntry extension is not present.
Fixes remaining dependency on GuidedBugEntry.
CyberShadow
force-pushed
the
instant-search-wo-guidedbugentry
branch
from
c3529aa to
74347bf
Compare
dylanwh
approved these changes
Apr 8, 2018
dylanwh
pushed a commit
that referenced
this pull request
Jun 28, 2020
* instant-search.js: Don't fail if product map isn't loaded getProduct had a hard dependency on the 'products' object, which is provided by products.js from the GuidedBugEntry extension. Check if the products variable exists before attempting to use it. This can happen when loading products.js fails, which in turn can happen when the GuidedBugEntry extension isn't present. * Instant search: Don't load products.js without GuidedBugEntry Fixes a 404 if the GuidedBugEntry extension is not present. * instant-search.js: Use throbber.gif from core Fixes remaining dependency on GuidedBugEntry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instant search had a little bit of hard-coded references to GuidedBugEntry's products.js.
Refactor these so GuidedBugEntry can gracefully inject the product synonyms remains a TODO, but for now, allow instant search to work on its own.