Skip to content

Add threeDSecure params on create order endpoint as optional#43

Merged
moniveloso merged 1 commit into
mainfrom
moni/add-threeDSecure-create-order
May 28, 2026
Merged

Add threeDSecure params on create order endpoint as optional#43
moniveloso merged 1 commit into
mainfrom
moni/add-threeDSecure-create-order

Conversation

@moniveloso
Copy link
Copy Markdown
Contributor

@moniveloso moniveloso commented May 26, 2026

Copilot AI review requested due to automatic review settings May 26, 2026 19:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR adiciona suporte a parâmetros de 3D Secure no payload tipado de criação de pedidos (/v2/orders), permitindo enviar o objeto threeDSecure quando necessário, mantendo-o opcional no OrderPayload.

Changes:

  • Adiciona novos dataclasses para representar o bloco threeDSecure (browser, endereços e cardHolder).
  • Inclui threeDSecure como campo opcional em OrderPayload.
  • Adiciona testes cobrindo envio do threeDSecure via payload tipado e cenário de erro da API para dados 3DS inválidos.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
barte/models.py Introduz modelos tipados para threeDSecure e adiciona threeDSecure opcional no OrderPayload.
tests/test_client.py Adiciona testes para criação de order com payload tipado incluindo 3DS e validação de erro 3DS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread barte/models.py
Comment thread tests/test_client.py Outdated
@moniveloso moniveloso force-pushed the moni/add-threeDSecure-create-order branch from af904eb to 826b7b5 Compare May 26, 2026 19:50
Copilot AI review requested due to automatic review settings May 26, 2026 20:13
@moniveloso moniveloso force-pushed the moni/add-threeDSecure-create-order branch 2 times, most recently from 826b7b5 to 339c112 Compare May 26, 2026 20:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread barte/models.py
Comment thread barte/models.py
Comment thread tests/test_client.py Outdated
@moniveloso moniveloso force-pushed the moni/add-threeDSecure-create-order branch from 339c112 to abf6e74 Compare May 26, 2026 20:26
@moniveloso moniveloso requested a review from a team May 26, 2026 20:51
@moniveloso moniveloso merged commit 6792e9b into main May 28, 2026
16 checks passed
@moniveloso moniveloso deleted the moni/add-threeDSecure-create-order branch May 28, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants