Fixed-length lists, host side - #12315
Conversation
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
|
TODO: Check whether the standard name fixed-length lists is used over fixed size lists. |
|
What's remaining for this? |
I didn't find the time to add a proper test case. And I (non-blockingly) wait for a new wasm-tools release to do the renaming in one row. |
8d18537 to
9157634
Compare
cpetig
left a comment
There was a problem hiding this comment.
I am not sure whether the O(n) constraint applies to the host side as the user always controls the data types (and dimensions) added on the host side, but if so I will gladly investigate into a different solution.
7e7faa7 to
be79c14
Compare
c8a031d to
30fc6e4
Compare
|
@alexcrichton would you please take another look at my latest fixes? |
alexcrichton
left a comment
There was a problem hiding this comment.
Two minor thoughts from me but otherwise looks great, thanks!
Replace the todo's with proper code and add a host side test case.
Implements #12279
Includes all the commits on #10619 , so that one should be merged first.