fix(chat): inline, persistent subagent cards (F5 close-out + duplicate-card fix) by blove · Pull Request #711 · cacheplane/angular-agent-framework

blove · 2026-06-19T23:58:46Z

Summary

Closes capability gap F5 — and fixes a real, transport-agnostic framework defect a live smoke uncovered along the way.

F5's premise was wrong. A live-LLM smoke of cockpit/ag-ui/subagents showed the AG-UI adapter does render and stream a chat-subagent-card (the audit's "renders as a plain tool row, no card" was a timing artifact of the transient active-only card). The real defect: <chat-subagents [agent]> was mounted inside the per-assistant-message ai template of the <chat> composition but bound the whole agent's subagents(), so it re-rendered the same active cards once per assistant message → duplicate cards. After completion the only durable trace was a generic "called task" chip.

The fix: the spawning task tool call now renders as an inline chat-subagent-card in chat-tool-calls — anchored to its message, replacing the generic chip. Running = expanded/live, completed = collapsed summary (▸ research ✓ · 1 message). The duplicate per-message <chat-subagents> mount is removed. Keyed on toolCallId, so it fixes both transports; ChatSubagentsComponent stays exported as a primitive.

Changes (all in `libs/chat`)

chat-tool-calls: renders a chat-subagent-card (ungrouped) for any tool call whose id is in agent.subagents(); normal calls unchanged.
chat composition: dropped the duplicate per-message <chat-subagents> mount.
chat-subagent-card: message count moved to the always-visible chat-trace meta slot so the collapsed (done) summary shows it.
e2e: cockpit/ag-ui/subagents now asserts the card (presence + persistence + no-duplicate == subs.size) instead of the generic chip.

Verification

nx run-many -t test lint build --projects=chat — green (new TDD specs in all three components).
Built all affected demos: cockpit ag-ui/chat subagents + examples chat/ag-ui — green.
e2e: cockpit-ag-ui-subagents (card-asserted) + cockpit-chat-subagents — green.
Live re-smoke (real OpenAI, AG-UI): 3 subagents → 3 cards, 0 duplicate ticks, persist + collapse-on-done, 0 NG0956, 0 leftover task chips. Before/after screenshots in the thread.

Notes

LangGraph agent.subagents() doesn't populate under aimock replay (atomic replay omits subgraph namespace events), so the inline card can't be e2e-asserted on the chat cockpit — same documented limitation as the transient card; it works live (the canonical examples/chat already renders LangGraph subagent cards live). No regression there: the task call falls back to a generic chip under aimock exactly as before.

Spec: docs/superpowers/specs/2026-06-19-subagent-card-inline-persistent-design.md · Plan: docs/superpowers/plans/2026-06-19-subagent-card-inline-persistent.md

🤖 Generated with Claude Code

…se-out)

…o spawning task call)

…per-message mount Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…ted; duplicate-mount defect fixed)

vercel · 2026-06-19T23:58:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
threadplane	Ready	Preview, Comment	Jun 20, 2026 12:14am

…ent-verify

github-actions · 2026-06-19T23:59:35Z

Claude encountered an error after 4m 17s —— View job

PR Review in Progress

Read CLAUDE.md for repo guidelines
Read the PR diff and changed files
Review correctness and Angular/RxJS pitfalls
Check TypeScript type safety
Assess test coverage
Post findings

github-actions

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

github-actions · 2026-06-20T00:00:32Z

Claude encountered an error after 2m 18s —— View job

PR Review in Progress

Read CLAUDE.md for repo guidelines
Read the PR diff and changed files
Review correctness and Angular/RxJS pitfalls
Check TypeScript type safety
Assess test coverage
Post findings

github-actions · 2026-06-20T00:04:00Z

@@ -54,7 +57,9 @@ interface Group {
  `],
  template: `
    @for (group of groups(); track $index) {


Pre-existing but now more impactful: track $index can desync expansion state when subagent groups arrive mid-list.

Before this PR, subagent cards lived in a separate <chat-subagents> component and never touched the groups() array. Now they do. When subagents arrive one-by-one (common during streaming), the subagent group replaces the generic chip in-place at the same index — so same-named adjacent calls that were previously merged into one group may split into N groups, shifting all subsequent group indices. Any user-expanded group below the split point will appear collapsed.

In practice this only bites when multiple same-name task calls arrive and subagents populate one at a time. Tracking by a stable key would eliminate the risk:

Suggested change

@for (group of groups(); track $index) {

@for (group of groups(); track group.calls[0].id) {

…ent-verify

github-actions · 2026-06-20T00:05:27Z

Claude finished @blove's task in 3m 8s —— View job

PR Review — fix(chat): inline, persistent subagent cards

Read CLAUDE.md for repo guidelines
Read the PR diff and changed files
Review correctness and Angular/RxJS pitfalls
Check TypeScript type safety
Assess test coverage
Post findings

Summary

The fix is correct and the design is clean. Moving the subagent card rendering into chat-tool-calls — keyed on toolCallId — elegantly solves the duplicate-mount root cause, and the persistence-on-complete behavior falls out naturally since the group is never torn down. Two issues worth addressing:

Issues

1. Index-keyed expansion state (pre-existing, made more visible here) — flagged in two related inline comments:

The existing review already flags track $index for DOM reconciliation. There's a deeper half: expandedGroups().has($index) resolves expansion by current render position. When groups() recomputes mid-stream (e.g. a subagent card inserts at position 0, shifting a user-expanded group from index 1 to index 2), the expanded group renders collapsed. The complete fix is to key expandedGroups by calls[0].id rather than by position — see the inline comment at line 64.

2. excludeToolNames silently suppresses subagent cards — see inline at line 126. The excludeSet filter runs before the subs.has(tc.id) check, so excludeToolNames: ['task'] removes the spawning call from consideration before the subagent branch is reached. No chip and no card renders — the subagent is silently dropped. Either document this interaction on the excludeToolNames JSDoc, or let subagent-backed calls bypass the filter.

Looks good

The !last.subagent guard on sameName correctly prevents non-subagent calls from merging into a subagent group on either side.
agent.subagents?.() ?? new Map() correctly handles agents without the subagents projection.
ChatSubagentsComponent remains exported from public-api.ts — no public API regression.
Test coverage is solid: unit specs cover the single-card, two-card, and no-duplicate-mount scenarios; the e2e now asserts card presence + count parity with subs.size.
The traceMeta slot move for message count is the right fix so it shows in collapsed state.

github-actions · 2026-06-20T00:08:14Z

+        <chat-subagent-card [subagent]="group.subagent" />
+      } @else if (group.calls.length > 1 && !group.templateRef) {
        <!-- Default grouped strip -->
        @let expanded = expandedGroups().has($index);


Deeper side of the track $index issue: expandedGroups is also index-keyed.

The existing review flags the track $index risk for DOM reconciliation; there's a complementary issue here. Even after adopting track group.calls[0].id, this line resolves expanded state by the current render index. When groups() recomputes mid-stream (e.g. a subagent card inserts at index 0, shifting everything below it), a group the user already expanded at index 1 now appears at index 2 — but expandedGroups still holds {1}, so it renders collapsed.

A complete fix pairs the tracking change with an ID-keyed expansion map:

Suggested change

@let expanded = expandedGroups().has($index);

@let expanded = expandedGroups().has(group.calls[0].id);

…and in the component class, change the signal + toggle to use the call ID:

private readonly _expandedGroups = signal(new Set<string>()); toggleGroup(groupId: string): void { this._expandedGroups.update(prev => { const next = new Set(prev); next.has(groupId) ? next.delete(groupId) : next.add(groupId); return next; }); }

The button's (click) binding would pass group.calls[0].id instead of $index. This is a pre-existing issue that this PR makes more visible — happy to treat it as a follow-up if preferred.

github-actions · 2026-06-20T00:08:23Z

@@ -119,14 +124,23 @@ export class ChatToolCallsComponent {
  readonly groups = computed((): Group[] => {
    const excludeSet = new Set(this.excludeToolNames());
    const calls = this.toolCalls().filter(tc => !excludeSet.has(tc.name));


excludeToolNames silently suppresses subagent cards.

The excludeSet filter runs before the subagent check. If a consumer passes excludeToolNames: ['task'], the spawning task call is removed from calls before we ever look it up in subs, so no chat-subagent-card renders. The subagent is silently swallowed — no chip, no card.

This may be intentional (opt-out of all task rendering), but it's a footgun: the name excludeToolNames reads like "suppress the generic chip", not "also suppress the subagent card". Worth either:

Documenting this interaction on the excludeToolNames JSDoc, or

Checking subs before filtering, so the subagent card is always rendered regardless of exclusion.

Fix this →

… for recent PRs (#719) Documents user-facing surfaces landed since 0.0.49 that had no narrative docs (API reference is bot-generated; these are the hand-written guides): - chat-subagent-card: correct stale "latest message" claim — the card now renders the full subagent transcript (streaming markdown + reasoning + tool-call cards) on <chat-trace>, auto-expanding while running (#692, #711) - changelog: un-freeze from 0.0.49 → 0.0.52; add classified errors + Retry (#693), injectThreadRouting (#697), full-transcript subagent cards, typed DX - new Error Handling guide: AgentError/AgentErrorKind, toAgentError, isAbortError, agent.retry(), the built-in <chat-error> Retry UX (#693) - new Client Tools guide: tools/action/view/ask with typed ViewProps/ToolArgs and typed agent state via createAgentRef (#685) - provideAgent reference: clientOptions + app-wide LANGGRAPH_CLIENT_OPTIONS retry-budget token with precedence (#681); Typed state via AgentRef (#685) - register both new guides in docs-config nav Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

blove and others added 7 commits June 19, 2026 16:07

docs: design for inline persistent subagent cards (F5 real-defect clo…

5ec71df

…se-out)

docs: implementation plan for inline persistent subagent cards

34e0b1b

feat(chat): chat-tool-calls renders subagent cards inline (anchored t…

bb09864

…o spawning task call)

fix(chat): render subagent cards once via tool-calls; drop duplicate …

0c4ae3f

…per-message mount Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(chat): show subagent message count in collapsed card summary

b05a8e3

test(cockpit): assert inline persistent subagent card (chip → card)

9f9f84a

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(ag-ui): close F5 — inline persistent subagent card (premise refu…

c1e99da

…ted; duplicate-mount defect fixed)

blove enabled auto-merge (squash) June 19, 2026 23:58

Merge remote-tracking branch 'origin/main' into claude/f5-ag-ui-subag…

77791a8

…ent-verify

github-actions Bot approved these changes Jun 20, 2026

View reviewed changes

github-actions Bot reviewed Jun 20, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into claude/f5-ag-ui-subag…

c61c226

…ent-verify

github-actions Bot reviewed Jun 20, 2026

View reviewed changes

vercel Bot deployed to Preview – threadplane June 20, 2026 00:14 View deployment

blove merged commit 31cefc8 into main Jun 20, 2026
23 checks passed

This was referenced Jun 20, 2026

feat(cockpit): chat/subagents renders inline subagent cards (real subgraph + aimock e2e) #718

Merged

docs: cover error UX, client tools, typing & retry budget for recent PRs #719

Merged

blove mentioned this pull request Jun 20, 2026

fix(examples): drop redundant subagents sidebar tray in canonical demo (post-#711 dedup) #722

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(chat): inline, persistent subagent cards (F5 close-out + duplicate-card fix)#711

fix(chat): inline, persistent subagent cards (F5 close-out + duplicate-card fix)#711
blove merged 9 commits into
mainfrom
claude/f5-ag-ui-subagent-verify

blove commented Jun 19, 2026

Uh oh!

vercel Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot commented Jun 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot Jun 20, 2026

Uh oh!

github-actions Bot Jun 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	@for (group of groups(); track $index) {
	@for (group of groups(); track group.calls[0].id) {

	@let expanded = expandedGroups().has($index);
	@let expanded = expandedGroups().has(group.calls[0].id);

Conversation

blove commented Jun 19, 2026

Summary

Changes (all in libs/chat)

Verification

Notes

Uh oh!

vercel Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review in Progress

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review in Progress

Uh oh!

github-actions Bot Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review — fix(chat): inline, persistent subagent cards

Summary

Issues

Looks good

Uh oh!

github-actions Bot Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Changes (all in `libs/chat`)

vercel Bot commented Jun 19, 2026 •

edited

Loading

github-actions Bot commented Jun 19, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading