Skip to content

fix(examples): drop redundant subagents sidebar tray in canonical demo (post-#711 dedup) #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blove wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −21
Open

fix(examples): drop redundant subagents sidebar tray in canonical demo (post-#711 dedup) #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cockpit/ag-ui/subagents/angular/src/app/subagents.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import { ExampleChatLayoutComponent } from '@threadplane/example-layouts';
* subagent-specific wiring is needed in the component: when the orchestrator
* dispatches a `task` tool call, the backend converts the subagent_activity
* CUSTOM events into native AG-UI ACTIVITY events, the @threadplane/ag-ui
* reducer projects them onto `agent.subagents()`, and <chat> renders a
* <chat-subagents> live card for each running subagent.
* reducer projects them onto `agent.subagents()`, and <chat> renders each
* dispatch inline as a persistent `chat-subagent-card`.
*
* Demonstrates the chat-runtime decoupling: same <chat> composition as the
* LangGraph cockpit, AG-UI runtime instead of LangGraph.
Expand Down
12 changes: 0 additions & 12 deletions examples/chat/angular/src/app/shell/demo-shell.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,6 @@
border-radius: var(--ngaf-chat-radius-card, 10px);
}

.demo-shell__subagents {
position: fixed;
left: 50%;
bottom: 96px;
transform: translateX(-50%);
z-index: 997;
width: min(640px, calc(100vw - 32px));
display: flex;
flex-direction: column;
gap: 8px;
}

.demo-shell__theme-toggle {
width: 28px;
height: 28px;
Expand Down
5 changes: 0 additions & 5 deletions examples/chat/angular/src/app/shell/demo-shell.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,6 @@
<chat-interrupt-panel [agent]="agent" (action)="onInterruptAction($event)" />
</div>
}
@if (agent.subagents && agent.subagents().size > 0) {
<div class="demo-shell__subagents" role="region" aria-label="Active subagents">
<chat-subagents [agent]="agent" />
</div>
}
</div>

<chat-history-search-palette
Expand Down
2 changes: 0 additions & 2 deletions examples/chat/angular/src/app/shell/demo-shell.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { DEMO_AGENT_REF, type DemoState } from './agent-ref';
import { ThreadplaneTelemetryService } from '@threadplane/telemetry/browser';
import {
ChatInterruptPanelComponent,
ChatSubagentsComponent,
ChatSidenavComponent,
ChatSidenavScrimComponent,
ChatHistorySearchPaletteComponent,
Expand Down Expand Up @@ -72,7 +71,6 @@ function parseUrl(url: string): { mode: DemoMode; threadId: string | null } {
imports: [
RouterOutlet,
ChatInterruptPanelComponent,
ChatSubagentsComponent,
ChatSidenavComponent,
ChatSidenavScrimComponent,
ChatHistorySearchPaletteComponent,
Expand Down
Loading