Accept tap as a press alias - #1052
Closed
vku2018 wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks @vku2018 — this landed in parallel with #1053, which implements the same alias through the existing |
thymikee
added a commit
that referenced
this pull request
Jul 3, 2026
* feat: accept tap as an alias of press * test: restore #1036 ordering regression coverage, assert tap dispatches press Making tap a real alias deleted the only tests covering unknown-command-before-flag-validation ordering (they used tap as the unknown command). Restore them with a genuinely unknown command, and strengthen the alias test to assert the dispatched call records press with positionals preserved instead of merely not-erroring. * test: cover tap alias composing with the bare-ref hint Adopted from #1052 (credit: @vku2018): tap e3 must normalize to press and then surface the @e3 suggestion, proving the alias and the bare-ref hint compose instead of masking each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tapcommand topressbefore dispatch and remove the old unknown-command suggestion path.press/clickremain canonical while documenting thetapalias once.tap @e3records as canonicalpress @e3.Fixes #1050
Tests
pnpm exec vitest run src/utils/__tests__/args.test.ts src/daemon/__tests__/session-store.test.ts src/__tests__/cli-help.test.tspnpm formatpnpm check:quickgit diff --check -- src/__tests__/cli-help.test.ts src/cli/parser/args.ts src/cli/parser/cli-help.ts src/daemon/__tests__/session-store.test.ts src/utils/__tests__/args.test.ts