Skip to content

Accept tap as a press alias - #1052

Closed
vku2018 wants to merge 1 commit into
callstack:mainfrom
vku2018:tap-press-alias
Closed

Accept tap as a press alias#1052
vku2018 wants to merge 1 commit into
callstack:mainfrom
vku2018:tap-press-alias

Conversation

@vku2018

@vku2018 vku2018 commented Jul 3, 2026

Copy link
Copy Markdown

Summary

  • Normalize the CLI tap command to press before dispatch and remove the old unknown-command suggestion path.
  • Update workflow help so press/click remain canonical while documenting the tap alias once.
  • Cover parser, CLI JSON dispatch, and session script recording so tap @e3 records as canonical press @e3.

Fixes #1050

Tests

  • pnpm exec vitest run src/utils/__tests__/args.test.ts src/daemon/__tests__/session-store.test.ts src/__tests__/cli-help.test.ts
  • pnpm format
  • pnpm check:quick
  • git diff --check -- src/__tests__/cli-help.test.ts src/cli/parser/args.ts src/cli/parser/cli-help.ts src/daemon/__tests__/session-store.test.ts src/utils/__tests__/args.test.ts

thymikee added a commit that referenced this pull request Jul 3, 2026
Adopted from #1052 (credit: @vku2018): tap e3 must normalize to press
and then surface the @e3 suggestion, proving the alias and the bare-ref
hint compose instead of masking each other.
@thymikee

thymikee commented Jul 3, 2026

Copy link
Copy Markdown
Member

Thanks @vku2018 — this landed in parallel with #1053, which implements the same alias through the existing normalizeCommandAlias path and keeps the unknown-command suggestion machinery + the #1036 ordering regression tests that this diff removes. Rather than lose your work: your tap×bare-ref interplay test was genuinely additive and is now in #1053 with credit (see the latest commit there). Recommend closing this one in favor of #1053 — and the test contribution is appreciated.

thymikee added a commit that referenced this pull request Jul 3, 2026
* feat: accept tap as an alias of press

* test: restore #1036 ordering regression coverage, assert tap dispatches press

Making tap a real alias deleted the only tests covering
unknown-command-before-flag-validation ordering (they used tap as the
unknown command). Restore them with a genuinely unknown command, and
strengthen the alias test to assert the dispatched call records press
with positionals preserved instead of merely not-erroring.

* test: cover tap alias composing with the bare-ref hint

Adopted from #1052 (credit: @vku2018): tap e3 must normalize to press
and then surface the @e3 suggestion, proving the alias and the bare-ref
hint compose instead of masking each other.
@thymikee thymikee closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make tap a real alias of press

3 participants