fix: centralize known cli command detection - #1055
Closed
thymikee wants to merge 1 commit into
Closed
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Sequencing note: this overlaps #1057 and both close #1043. I recommend not merging both. #1057 has broader drift coverage because it parses cli.ts with TypeScript and catches property-access command comparisons such as options.command, while this PR regexes only bare command === literal branches. Please close this one or retarget it only if there is unique coverage to preserve. |
thymikee
added a commit
that referenced
this pull request
Jul 3, 2026
Folds #1055's telemetry into this branch: known-command fall-through now emits cli_known_command_unhandled at error level alongside the distinct user-facing message, so catalog/dispatch drift is visible in diagnostics as well as to the user who hits it.
Member
Author
|
Superseding via #1057, which implements the same |
thymikee
added a commit
that referenced
this pull request
Jul 3, 2026
Folds #1055's telemetry into this branch: known-command fall-through now emits cli_known_command_unhandled at error level alongside the distinct user-facing message, so catalog/dispatch drift is visible in diagnostics as well as to the user who hits it.
thymikee
added a commit
that referenced
this pull request
Jul 3, 2026
Folds #1055's telemetry into this branch: known-command fall-through now emits cli_known_command_unhandled at error level alongside the distinct user-facing message, so catalog/dispatch drift is visible in diagnostics as well as to the user who hits it.
thymikee
added a commit
that referenced
this pull request
Jul 3, 2026
* refactor: centralize known cli command checks * feat: emit drift diagnostic for registered-but-unhandled commands Folds #1055's telemetry into this branch: known-command fall-through now emits cli_known_command_unhandled at error level alongside the distinct user-facing message, so catalog/dispatch drift is visible in diagnostics as well as to the user who hits it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes known CLI command detection in src/command-catalog.ts and has the parser consume that shared predicate before flag-support validation, preserving the #1038 unknown-command precedence.
Adds focused drift coverage for public, local, internal, help, and literal cli.ts command branches so parser-level unknown-command handling stays aligned with CLI dispatch.
Closes #1043
Validation
Focused parser/CLI-help tests passed: pnpm exec vitest run src/utils/tests/args.test.ts src/tests/cli-help.test.ts.
Formatting passed: pnpm format.
Quick checks passed: pnpm check:quick.