fix: clarify prepare ios-runner timing overlap - #1058
Merged
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
commented
Jul 3, 2026
thymikee
left a comment
Member
Author
There was a problem hiding this comment.
Review: LGTM. The additive design is exactly right: legacy top-level fields stay for compatibility (now documented as overlapping diagnostics) and timing.additiveParts provides disjoint parts that sum exactly to total — verified the arithmetic in the fixtures (10642 + 1993 + 14702 = 27337, which is the real measurement from #1046 turned into the test). 296 tests + provider 87/87 + typecheck green locally. The prepare help-text rewrite also quietly improved the CI guidance — good touch.
thymikee
force-pushed
the
fix/prepare-ios-runner-timing-overlap
branch
from
July 3, 2026 10:21
eb4b756 to
5bdb772
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1046.
Adds machine-readable prepare timing guidance so agents do not add overlapping fields as wall-clock totals: legacy buildMs/connectMs/healthCheckMs stay in place, while timing.additiveParts and timing.containment explain the safe additive breakdown. Also mirrors the containment label in runner diagnostics and documents it in CLI help, typed client comments, and website command docs.
Touched files: 8.
Validation
Focused prepare/runner timing tests passed: pnpm exec vitest run src/daemon/handlers/tests/session.test.ts src/platforms/apple/core/tests/runner-command-retry.test.ts src/utils/tests/args.test.ts.
Static quick checks passed: pnpm check:quick. Formatter passed: pnpm format. Build passed: pnpm build.
Residual risk: pnpm check:unit was attempted after building dist. The first run reached smoke tests and failed because dist was missing before the build. After building, reruns hit broad unrelated timeout/mocked-tool failures across Android, Apple, archive, Metro, and upload tests, while the focused touched tests stayed green.