Skip to content

fix: make artifact inventory consumption deterministic on download #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Jul 4, 2026
Merged

fix: make artifact inventory consumption deterministic on download #1073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/daemon/downloadable-artifact-http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,14 @@ async function handleArtifactDownload(
didCleanupArtifact = true;
cleanupDownloadableArtifact(artifactId);
};
// Consume before the final chunk is written to the client: fetch treats a
// download as complete once content-length bytes arrive, which can happen
// before this stream emits 'end' (that needs one more threadpool read).
let bytesSent = 0;
stream.on('data', (chunk: string | Buffer) => {
bytesSent += chunk.length;
if (bytesSent >= artifact.sizeBytes) cleanupCompletedDownload();
});
stream.on('end', cleanupCompletedDownload);
res.on('finish', cleanupCompletedDownload);
res.on('close', () => {
Expand Down
Loading