fix(cli): compact stale device status - #1388
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
Reviewed exact head e3be0cd. P1 — shell-quote scoped stale-inspection selectors. buildStaleInspectionCommand interpolates selector values verbatim. A common selector such as --device "iPhone 17 Pro" is rendered as --device iPhone 17 Pro --stale, which no longer parses as the original selector. Use shellQuoteIfNeeded for platform/device/udid/serial and add a spaced/metacharacter regression; the current test covers only a shell-safe serial. Otherwise the daemonless/read-only route, stale classification, bounded default output, schema/help/docs, and green CI look good. No ready label until this is fixed. |
|
Addressed the confirmed review in 987955a. Generated stale-inspection follow-up commands now apply shellQuoteIfNeeded to platform, device, UDID, and serial selectors. Added a regression using a device name containing spaces and a semicolon, while preserving the daemonless, compact status route. Validation: format, typecheck, lint, focused Vitest, integration-progress, and Fallow all pass. |
|
Reviewed exact head Residual risk: no separately authorized cross-vendor review ran. |
* origin/main: docs(adr): rules-first ADR restructure + ADR 0017 proposal (unified event journal) (#1399) feat: add first-class Vega VVD TV support (#1396) fix(replay): preserve cwd scope for opened sessions (#1401) docs: restructure AGENTS.md and CONTEXT.md for progressive disclosure (#1402) fix(cli): compact stale device status (#1388) feat: add WebView accessibility lab (#1397) feat: parameterize sensitive recorded inputs (#1369) fix(daemon): keep an active replay session's daemon alive over the CLI path (#1390) # Conflicts: # docs/adr/0012-interactive-replay.md
Summary
Make normal
device statusoutput compact by summarizing proven-stale advisory claims.Add selector-preserving
--staleinspection, help, docs, and coverage without implying unsafe cleanup.Validation