fix(ci): drop pipefail from the nightly Android emulator script - #1512
Merged
Conversation
android-emulator-runner runs the script with /usr/bin/sh, which is dash on
ubuntu runners and rejects `-o pipefail`:
/usr/bin/sh: 1: set: Illegal option -o pipefail
The Android full emulator suite has therefore failed on every nightly since
it landed in #1484, aborting before the first command. The sibling emulator
scripts in android.yml and perf-nightly.yml already use `set -eu`/`set -e`;
match them. The serial assignment stays guarded by `test -n".
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Android Full Emulator Suitejob in Replay Nightly has failed on every run since it landed in #1484 — it never once passed. It aborts before the first command:reactivecircus/android-emulator-runnerexecutes itsscript:with/usr/bin/sh, which is dash on ubuntu runners, and dash has nopipefailoption. The job burns a full emulator boot (~3 min) and then dies on line 1.Latest occurrence: run 30603457576 (2026-07-31), same in the 2026-07-30 17:40 nightly. The last green nightly (2026-07-30 09:16) predates the job.
Fix
Use
set -eu, matching the two sibling emulator scripts that already run correctly under the same action:.github/workflows/android.yml→set -eu.github/workflows/perf-nightly.yml→set -eDropping
pipefailloses nothing here: the only pipeline is theANDROID_SERIALassignment, which is already validated by thetest -n \"$ANDROID_SERIAL\"guard on the next line — the same contract android.yml relies on.Verification
Reproduced and verified against a real dash (
/bin/dash), which emits the identical error:The full 16-line script body extracted from the workflow also passes
dash -n(no other bashisms). Swept everyandroid-emulator-runnerscript:block in the repo — this was the only one affected.Nightly is the only place this job runs, so the real proof is the next scheduled run (or a manual dispatch).