refactor(ios-runner): restrict the tap-witness synthesized type route to the bare submit key

[thymikee]

Summary

Stacked on #2834.

The tap-witness synthesized route now admits only what the daemon sends it: no mode plus "\n". Ordinary text uses append mode and keeps its production path. The dormant commit wait and its tests are deleted. fill's replacement wait and shared helpers stay.

Tests now send daemon request shapes: append text asserting field values, plus no-mode "\n" route and refusal tests. Touched tests live in UnitTests/. The hint and commands.md now name only type "\n".

Issue line refs have moved; the facts still hold. 13 files. Closes #2800

Validation

Rebased onto main at a913cb222. Signed macOS host lane: 233/233 at 60e533284. check:affected --run is green at this head. The evidence below is from before the rebase.

SHA 7af257bee.

• pnpm check:affected --run (base refactor(ios-runner): drop the runner's snapshot warning text; the verdict carries every disclosure #2834) passed, including check:xctest-selection.
• macOS host lane: 231/231 pass. Planting the old gate turns the gate test red.
• iOS sim: the build compiles and non-launching tests pass. The runner host app traps without UIScene on every local iOS 27 runtime, including untouched tests, so CI ios.yml owns the app-launching tests.
• Live on iPhone 17 Pro, fresh runner, Settings search:
  • Keyboard visible: type wif, then type i; get text read wifi.
  • Hardware keyboard, soft keyboard hidden: type blue, then type tooth → bluetooth.
  • type "\n" submitted the search.
  • Gap: the runner counted the minimized keyboard as visible, so the tap-witness route was not reached live.
• Review: fixed the hint, witness asserts, refusal test, mid-test skip, duplicate test and issue refs. Rejected a golden table and helper inlining (the issue fixes both), and 1874-diagnose.yml (ios: fill's synthesized-replacement route lands a corrupted value (traced: 11 chars requested, 7 observed, frozen) #2080).

🤖 Generated with Claude Code

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-23 18:24 UTC

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	4.79 MB	4.79 MB	-3.2 kB
Package (unpacked)	4.79 MB	4.79 MB	-3.2 kB
Package (download)	1.43 MB	1.43 MB	-363 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	28.0 ms	28.7 ms	+0.7 ms
CLI --help	79.8 ms	81.5 ms	+1.7 ms

[thymikee]

This looks ready to merge at 7af257b. The route restriction to the bare submit key is sound by code reading; the old commit wait always returned .unobservable for text containing \n, which maps to nil, so treating the two paths as equivalent doesn't need a live hidden-keyboard run to hold. Not blocking: the diagnose workflow default (.github/workflows/1874-diagnose.yml#L26) now points at a test that asserts route xctest-element and never reaches a [DEBUG-1874] commit wait, so a default dispatch won't collect cadence lines; the author can point it at a replacement-route test or retire it under #2080, whichever comes first.

The rewritten app-launching XCTests (append asserting xctest-element with the keyboard hidden, and the submit-key route) haven't run anywhere yet; the in-progress Smoke Tests job (ios.yml#L160-L178, "Run targeted iOS runner XCTest regressions") is their first execution, covering testBareTypeUsesTappedInputWhenSoftwareKeyboardIsHidden, testBareSubmitKey*, and testHealthyCoordinateTapPreservesBareTypingWitness directly. That job needs to pass before merge, and PR #2834 needs to land first.