Skip to content

feat: introduce first iteration of AnimatedFAB component - #2580

Merged
lukewalczak merged 13 commits into
mainfrom
feat/animated-extended-fab
Oct 19, 2021
Merged

lukewalczak merged 13 commits into
mainfrom
feat/animated-extended-fab

Conversation

@lukewalczak

@lukewalczak lukewalczak commented Mar 3, 2021

Copy link
Copy Markdown
Member

Summary

That PR introduces new component called AnimatedFAB which animates when extended. Along with new component two props were introduced:

  • extended - whether FAB should start animation to extend
  • animateFrom - indicates from which direction animation should be performed
ios android
ios_animated_fab android_gif_example

Test plan

@callstack-bot

callstack-bot commented Mar 3, 2021

Copy link
Copy Markdown

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions

Copy link
Copy Markdown

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak added the FAB label Apr 7, 2021
@lukewalczak
lukewalczak marked this pull request as ready for review April 7, 2021 15:16
Comment on lines +47 to +48
icon={'pencil'}
label={'Create'}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icon={'pencil'}
label={'Create'}
icon="pencil"
label="Create"

@MBach

MBach commented May 28, 2021

Copy link
Copy Markdown

Great job!
I hope it will be merged soon, I was looking for such feature since a long time

@github-actions

Copy link
Copy Markdown

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.

@github-actions github-actions Bot added the Stale label Jul 31, 2021
@iM-GeeKy

iM-GeeKy commented Aug 3, 2021

Copy link
Copy Markdown

@lukewalczak or @brunohkbx Is this still relevant? I would like to see this merged if possible.

@lukewalczak
lukewalczak force-pushed the feat/animated-extended-fab branch 2 times, most recently from 827bb50 to a637f14 Compare October 13, 2021 14:45
@lukewalczak
lukewalczak force-pushed the feat/animated-extended-fab branch from a637f14 to fcaefef Compare October 13, 2021 14:46
@github-actions

Copy link
Copy Markdown

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak
lukewalczak merged commit 9c2e84c into main Oct 19, 2021
@lukewalczak
lukewalczak deleted the feat/animated-extended-fab branch October 19, 2021 07:46
@lukewalczak

Copy link
Copy Markdown
Member Author

We are currently merging the PR to proceed with AnimatedFAB improvements. In the meantime component is ready only for development.

@lukewalczak
lukewalczak restored the feat/animated-extended-fab branch October 19, 2021 07:52
JKobrynski added a commit that referenced this pull request Sep 15, 2026
All 19 re-checked against 0.21.3 docs and source, the emulator, and the upstream tracker. None was an unreported agent-device bug: one fixed upstream (#2580), two documented, the rest our build, our runner, or not reproducible. File restructured accordingly; original numbers kept in brackets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants