chore: add test to ensure it is possible to trigger native event - #1114
Merged
mdjastrzebski merged 1 commit intoSep 15, 2022
Merged
Conversation
|
|
||
| // Those events ideally should be triggered through `fireEvent.scroll`, but they are handled at the | ||
| // native level, so we need to support manually triggering them | ||
| describe('native events', () => { |
Member
There was a problem hiding this comment.
Suggested change
| describe('native events', () => { | |
| describe('native event support', () => { |
Member
There was a problem hiding this comment.
I wonder if we should actually use host component event support instead, as by design we do not support "native" events.
mdjastrzebski
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for a behaviour we support (triggering event that don't exist on the JS side but are handled natively). It is however not tested, so I want to add test to make sure we don't lose this feature by mistake (see discussions in #1080 (comment)).