chore: ReactNative API assumptions early warning tests - #1143
Merged
Conversation
thymikee
reviewed
Sep 28, 2022
thymikee
left a comment
thymikee
left a comment
Member
There was a problem hiding this comment.
Not sure about the "tripwire" naming. I'd probably go with "host edge-cases" or so, but don't mind really.
thymikee
approved these changes
Sep 28, 2022
Member
Author
|
I will adjust the naming allong the lines of "API assumption" early warning test |
…eact-native-testing-library into chore/tripwire-tests # Conflicts: # src/__tests__/tripwire.test.tsx
mdjastrzebski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #1139 (comment) we would benefit from set of tests that would verify our assumptions around rendering of host elements for important React Native components, especially:
TextandTextInput. This PR adds such tests.Additionally, it adds internal
getHostSelf()helper function that allows for easily trading a host or compositeReactTestInstancefor its host counterpart (or itself).Test plan
Added tripwire tests
Added tests for
getHostSelf()