Skip to content

docs: update v12 migration guide - #1340

Merged
mdjastrzebski merged 3 commits into
callstack:v12from
pierrezimmermannbam:docs/updateV12MigrationGuide
Feb 21, 2023
Merged

docs: update v12 migration guide#1340
mdjastrzebski merged 3 commits into
callstack:v12from
pierrezimmermannbam:docs/updateV12MigrationGuide

Conversation

@pierrezimmermannbam

Copy link
Copy Markdown
Collaborator

Summary

Updates migration guide for v12 to include update of jest-native when using toBeOnTheScreen matcher

Test plan

@mdjastrzebski

mdjastrzebski commented Feb 21, 2023

Copy link
Copy Markdown
Member

@pierrezimmermannbam let's also add a top-level note that users should upgrade Jest Native to 5.4.2 along with RNTL v12.

@mdjastrzebski mdjastrzebski changed the title Docs/update v12 migration guide docs: update v12 migration guide Feb 21, 2023
@pierrezimmermannbam
pierrezimmermannbam force-pushed the docs/updateV12MigrationGuide branch from 3adcf28 to fa2c87e Compare February 21, 2023 11:41
@pierrezimmermannbam

Copy link
Copy Markdown
Collaborator Author

@mdjastrzebski I added a top level note

Comment thread website/docs/MigrationV12.md Outdated
@codecov

codecov Bot commented Feb 21, 2023

Copy link
Copy Markdown

Codecov Report

Base: 96.09% // Head: 96.09% // No change to project coverage 👍

Coverage data is based on head (9e3ea55) compared to base (42c271a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              v12    #1340   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          49       49           
  Lines        3280     3280           
  Branches      492      492           
=======================================
  Hits         3152     3152           
  Misses        128      128           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdjastrzebski
mdjastrzebski merged commit 211907a into callstack:v12 Feb 21, 2023
mdjastrzebski pushed a commit that referenced this pull request Mar 8, 2023
* docs: update migration guide to mention updating version of jest native

* docs: add note at top level to indicate it requires an update of jest native

* Update website/docs/MigrationV12.md

---------

Co-authored-by: pierrezimmermann <pierrez@nam.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants