feat: support pointerEvents - #655
Merged
Merged
Conversation
satya164
reviewed
Jan 21, 2021
Member
|
Let's support |
satya164
reviewed
Jan 21, 2021
Member
There was a problem hiding this comment.
Can you also add tests for following scenarios:
- Firing event on the same element which has
pointerEvents="none"(<Text onPress={handlePress} pointerEvents="none" />) - Firing event on the same element which has
pointerEvents="box-none"(<Text onPress={handlePress} pointerEvents="box-none" />) - Firing event on the same element which has
pointerEvents="box-only"(<Text onPress={handlePress} pointerEvents="box-only" />)
Contributor
Author
|
I don't think that |
thymikee
reviewed
Jan 26, 2021
thymikee
approved these changes
Jan 26, 2021
satya164
reviewed
Jan 26, 2021
satya164
left a comment
Member
There was a problem hiding this comment.
I think it would still be nice to have some tests which trigger onPress on the same element that has pointerEvents
thymikee
force-pushed
the
feat/supportPointerEvents
branch
from
February 5, 2021 13:59
547ed59 to
306e24b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows handling test cases that use
pointerEventswhich was mentioned in #650. I'm not sure if we should also additionally handle thebox-nonevalue.Fixes #650
Test plan
I've added 3 tests that check pointerEvents
noneandbox-onlyand also pointerEventsnonewith nested views.