Fix translations text not being found by getByText - #967
Closed
pierrezimmermannbam wants to merge 1 commit into
Closed
Fix translations text not being found by getByText#967pierrezimmermannbam wants to merge 1 commit into
pierrezimmermannbam wants to merge 1 commit into
Conversation
pierrezimmermannbam
marked this pull request as draft
May 1, 2022 19:42
pierrezimmermannbam
force-pushed
the
fix/trads
branch
from
May 1, 2022 19:55
ebe2047 to
4e06bea
Compare
Member
|
This issue is related to architecture discussion in #972.
|
Member
|
Closing as changes contained it the PR would break other features of RNTL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pr is still a draft. Fixes #937
Test plan