feat: runInBackground thread for iOS - #39
Merged
Merged
Conversation
zamotany
suggested changes
May 31, 2021
Comment on lines
+68
to
+85
| [self runInBackground:^(){ | ||
| if (!fetch) { | ||
| // Do nothing, chunk is already preloaded | ||
| resolve(nil); | ||
| } else { | ||
| reject(UnsupportedScheme, | ||
| [NSString stringWithFormat:@"Scheme in URL '%@' is not supported", chunkUrlString], nil); | ||
| NSURL *chunkUrl = [NSURL URLWithString:chunkUrlString]; | ||
| if ([[chunkUrl scheme] hasPrefix:@"http"]) { | ||
| [self downloadAndCache:chunkId chunkUrl:chunkUrl completionHandler:^(NSError *error) { | ||
| if (error) { | ||
| reject(ChunkDownloadFailure, error.localizedFailureReason, nil); | ||
| } else { | ||
| resolve(nil); | ||
| } | ||
| }]; | ||
| } else { | ||
| reject(UnsupportedScheme, | ||
| [NSString stringWithFormat:@"Scheme in URL '%@' is not supported", chunkUrlString], nil); | ||
| } |
Contributor
There was a problem hiding this comment.
I sugget to change it to:
if (!fetch) {
// Do nothing, chunk is already preloaded
resolve(nil);
} else {
[self runInBackground:^() {
...
}];
}To avoid unnecessarily spawning new threads.
zamotany
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added method
runInBackgroundwhich lets to run methodsloadChunk,preloadChunkandinvalidateChunkswithout blocking the UI thread for iOS.Test plan
Manually test
TesterAppusing 2s delay in methodsloadChunk,preloadChunkandinvalidateChunks.The app is responsive hence UI thread is not blocked.
ios.720.mov