Skip to content

Error ealier when framework names collide and clean up when resolved #365

Description

@kraenhansen

After #351 merged and while experimenting with #363 I had frameworks on the filesystem with different path but same identifiers and got this error while installing an app.

Please try again later. Found bundle at /Users/kraenhansen/Library/Developer/CoreSimulator/Devices/4EDDABA6-E72F-4FBF-85C5-576A9A9EA5F5/data/Library/Caches/com.apple.mobile.installd.staging/temp.nhmXW6/extracted/ReactTestApp.app/Frameworks/node-addon-examples--example-2-hello.framework with the same identifier (example-2.hello) as bundle at /Users/kraenhansen/Library/Developer/CoreSimulator/Devices/4EDDABA6-E72F-4FBF-85C5-576A9A9EA5F5/data/Library/Caches/com.apple.mobile.installd.staging/temp.nhmXW6/extracted/ReactTestApp.app/Frameworks/example-2--hello.framework

After deleting one of these, the error persisted.

Ideally - we should check and fail if Node-API frameworks collide and investigate if it would be possible to provide a better recovery method than cleaning the build folder.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Apple 🍎Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.)Host 🏡Our `react-native-node-api-modules` packageLinking 🔗Discovering and copying prebuilds from packages into the host

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions