Skip to content

docs: update README for NIP-05 and NIP-44#518

Merged
cameri merged 1 commit into
cameri:mainfrom
radosvet93:patch-1
Apr 18, 2026
Merged

docs: update README for NIP-05 and NIP-44#518
cameri merged 1 commit into
cameri:mainfrom
radosvet93:patch-1

Conversation

@radosvet93

@radosvet93 radosvet93 commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Added NIP-05 and NIP-44 from the list of protocols.

Description

Related Issue

#516

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

Removed NIP-05 and NIP-44 from the list of protocols.
Copilot AI review requested due to automatic review settings April 18, 2026 22:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the README “Features” section (supported NIPs list) in the project’s main documentation, but the actual diff content does not match the PR’s stated intent.

Changes:

  • Adds README entries indicating support for NIP-05 (DNS-based identifiers) and NIP-44 (versioned encrypted payloads).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines 51 to +65
@@ -61,6 +62,7 @@ NIPs with a relay-specific implementation are listed here.
- [x] NIP-28: Public Chat
- [x] NIP-33: Parameterized Replaceable Events
- [x] NIP-40: Expiration Timestamp
- [x] NIP-44: Encrypted Payloads (Versioned)
@radosvet93 radosvet93 changed the title Update README to remove NIP-05 and NIP-44 Update README for NIP-05 and NIP-44 Apr 18, 2026
@radosvet93 radosvet93 requested a review from Copilot April 18, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the README’s supported NIPs list to reflect additional protocol features already implemented in the codebase (per issue #516), improving user-facing documentation accuracy.

Changes:

  • Add NIP-05 to the “Features” supported NIPs checklist.
  • Add NIP-44 to the “Features” supported NIPs checklist.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cameri

cameri commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Hey @radosvet93 , appreciate the contribution. Are you a student of the Summer of Bitcoin 2026 program?

@cameri

cameri commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Thanks @radosvet93 .

@cameri cameri changed the title Update README for NIP-05 and NIP-44 docs: update README for NIP-05 and NIP-44 Apr 18, 2026
@cameri cameri merged commit 78e32bd into cameri:main Apr 18, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants