Skip to content

Fixes rendering issue with the Windows console#323

Merged
mreinstein merged 2 commits into
caolan:masterfrom
nycdotnet:fix-test-symbol-rendering-on-windows
Sep 7, 2016
Merged

Fixes rendering issue with the Windows console#323
mreinstein merged 2 commits into
caolan:masterfrom
nycdotnet:fix-test-symbol-rendering-on-windows

Conversation

@nycdotnet

@nycdotnet nycdotnet commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

Resolves #298

I made this as simple as possible. The fail character is just a literal x.

Before:
nodeunit-before

After:
nodeunit-after

@nycdotnet

Copy link
Copy Markdown
Contributor Author

Not quite sure why process couldn't be found on Node 0.12 - any ideas? The Node.js docs say it was added in v0.1.16. https://nodejs.org/api/process.html#process_process_platform I can get the platform from the 'os' module too.

@mreinstein

Copy link
Copy Markdown
Collaborator

@nycdotnet I think you don't need to explicitly require('process'); it's already added automatically.

@nycdotnet

Copy link
Copy Markdown
Contributor Author

That's exactly it. You learn something new every day.

http://stackoverflow.com/questions/30418677/unable-to-require-process

@mreinstein
mreinstein merged commit 378e4a6 into caolan:master Sep 7, 2016
@nycdotnet
nycdotnet deleted the fix-test-symbol-rendering-on-windows branch September 7, 2016 16:09
iminyukov pushed a commit to iminyukov/nodeunit that referenced this pull request Apr 23, 2018
…g-on-windows

Fixes rendering issue with the Windows console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants